Skip to content

Fix panic with empty attribute inner comment#6332

Merged
konstin merged 1 commit intoastral-sh:mainfrom
davidszotten:formatter-fix-panic-with-empty-attribute-inner-comment
Aug 4, 2023
Merged

Fix panic with empty attribute inner comment#6332
konstin merged 1 commit intoastral-sh:mainfrom
davidszotten:formatter-fix-panic-with-empty-attribute-inner-comment

Conversation

@davidszotten
Copy link
Contributor

Fixes #6181

@MichaReiser MichaReiser requested a review from konstin August 4, 2023 08:48
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

PR Check Results

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.01      8.9±0.08ms     4.6 MB/sec    1.00      8.8±0.08ms     4.6 MB/sec
formatter/numpy/ctypeslib.py               1.00  1783.6±12.14µs     9.3 MB/sec    1.00  1788.9±21.62µs     9.3 MB/sec
formatter/numpy/globals.py                 1.00    202.5±2.87µs    14.6 MB/sec    1.01    204.1±2.46µs    14.5 MB/sec
formatter/pydantic/types.py                1.00      3.8±0.04ms     6.7 MB/sec    1.01      3.8±0.07ms     6.7 MB/sec
linter/all-rules/large/dataset.py          1.02     12.5±0.12ms     3.3 MB/sec    1.00     12.3±0.09ms     3.3 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.02      3.2±0.04ms     5.2 MB/sec    1.00      3.1±0.03ms     5.3 MB/sec
linter/all-rules/numpy/globals.py          1.00    433.6±4.05µs     6.8 MB/sec    1.01    435.7±3.88µs     6.8 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.7±0.04ms     4.5 MB/sec    1.00      5.7±0.07ms     4.5 MB/sec
linter/default-rules/large/dataset.py      1.02      6.1±0.07ms     6.6 MB/sec    1.00      6.0±0.04ms     6.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01  1299.0±13.27µs    12.8 MB/sec    1.00  1285.2±16.86µs    13.0 MB/sec
linter/default-rules/numpy/globals.py      1.01    144.8±1.98µs    20.4 MB/sec    1.00    143.1±1.88µs    20.6 MB/sec
linter/default-rules/pydantic/types.py     1.02      2.7±0.03ms     9.3 MB/sec    1.00      2.7±0.05ms     9.5 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00     10.0±0.11ms     4.1 MB/sec    1.01     10.1±0.16ms     4.0 MB/sec
formatter/numpy/ctypeslib.py               1.00  1914.7±26.72µs     8.7 MB/sec    1.00  1919.8±33.82µs     8.7 MB/sec
formatter/numpy/globals.py                 1.00    207.2±4.32µs    14.2 MB/sec    1.05   217.2±13.40µs    13.6 MB/sec
formatter/pydantic/types.py                1.00      4.2±0.11ms     6.1 MB/sec    1.01      4.2±0.08ms     6.0 MB/sec
linter/all-rules/large/dataset.py          1.02     14.3±0.21ms     2.9 MB/sec    1.00     14.0±0.19ms     2.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.02      3.7±0.06ms     4.6 MB/sec    1.00      3.6±0.05ms     4.7 MB/sec
linter/all-rules/numpy/globals.py          1.01    440.6±9.20µs     6.7 MB/sec    1.00    436.6±8.67µs     6.8 MB/sec
linter/all-rules/pydantic/types.py         1.03      6.6±0.14ms     3.9 MB/sec    1.00      6.4±0.11ms     4.0 MB/sec
linter/default-rules/large/dataset.py      1.00      7.1±0.07ms     5.8 MB/sec    1.00      7.0±0.09ms     5.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1430.0±19.93µs    11.6 MB/sec    1.00  1436.9±35.73µs    11.6 MB/sec
linter/default-rules/numpy/globals.py      1.00    160.3±3.28µs    18.4 MB/sec    1.00    160.2±4.65µs    18.4 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.1±0.05ms     8.2 MB/sec    1.00      3.1±0.04ms     8.2 MB/sec

@konstin
Copy link
Member

konstin commented Aug 4, 2023

thanks

@konstin konstin merged commit fe97a2a into astral-sh:main Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Formatter panic with empty attribute inner comment

3 participants