Fix formatting of lambda star arguments#6257
Merged
charliermarsh merged 3 commits intoastral-sh:mainfrom Aug 2, 2023
Merged
Conversation
Previously, the ruff formatter was removing the star argument of `lambda` expressions when formatting. Given the following code snippet ```python lambda *a: () lambda **b: () ``` it would be formated to ```python lambda: () lambda: () ``` We fix this by checking for the presence of `args`, `vararg` or `kwarg` in the `lambda` expression, before we were only checking for the presence of `args`. Fixes astral-sh#5894
Contributor
Author
|
I don't know why the |
Contributor
PR Check ResultsBenchmarkLinuxWindows |
Member
|
Deleted is good! Deleted means exact compatibility with Black on that file. |
Contributor
Author
Ah nice! Do you know why the CI is failing? |
zanieb
reviewed
Aug 2, 2023
| # ...but we do preserve a trailing comma after the arguments | ||
| a = lambda b,: 0 | ||
|
|
||
| lambda *a: () |
Member
There was a problem hiding this comment.
Unfortunately you can do disturbing things like insert a comment between the star and the parameter. We'll probably want test coverage for cases like this:
(
lambda
*
# test
x: print(x)
)
Member
Hm I'm not sure if this panic is relevant?
but it detected a stability error
@konstin is probably best to direct you to debug that |
Member
|
I'll take a look. |
Member
|
fwiw i have improving the script on my agenda for tomorrow |
Member
|
Looks like it was an unrelated bug in our handling of (e.g.) |
konstin
added a commit
that referenced
this pull request
Aug 3, 2023
**Summary** Prompted by #6257 (comment), it tried to make the ecosystem script output on failure better understandable. All log messages are now written to a file, which is printed on error. Running locally progress is still shown. Looking through the log output i saw that we currently log syntax errors in input, which is confusing because they aren't actual errors, but we don't check that these files don't change due to parser regressions or improvements. I added `--files-with-errors` to catch that. **Test Plan** CI
konstin
added a commit
that referenced
this pull request
Aug 3, 2023
…6300) **Summary** Prompted by #6257 (comment), it tried to make the ecosystem script output on failure better understandable. All log messages are now written to a file, which is printed on error. Running locally progress is still shown. Looking through the log output i saw that we currently log syntax errors in input, which is confusing because they aren't actual errors, but we don't check that these files don't change due to parser regressions or improvements. I added `--files-with-errors` to catch that. **Test Plan** CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the ruff formatter was removing the star argument of
lambdaexpressions when formatting.Given the following code snippet
it would be formatted to
We fix this by checking for the presence of
args,varargorkwargin thelambdaexpression, before we were only checking for the presence ofargs.Fixes #5894
Test Plan
Add new tests cases.