Skip to content

Comments

Log configuration in ruff_dev#6193

Merged
konstin merged 2 commits intomainfrom
config_logging_in_ruff_dev
Jul 31, 2023
Merged

Log configuration in ruff_dev#6193
konstin merged 2 commits intomainfrom
config_logging_in_ruff_dev

Conversation

@konstin
Copy link
Member

@konstin konstin commented Jul 31, 2023

Summary This includes two changes:

  • Allow setting -v in ruff_dev, using the ruff_cli implementation
  • debug! which ruff configuration strategy was used

This is a byproduct of debugging #6187.

Test Plan n/a

@konstin
Copy link
Member Author

konstin commented Jul 31, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@konstin konstin mentioned this pull request Jul 31, 2023
Merged
Base automatically changed from formatter_ecosystem_ci_debugging to main July 31, 2023 12:45
@konstin konstin mentioned this pull request Jul 31, 2023
Merged
@konstin konstin added the formatter Related to the formatter label Jul 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023 •
edited
Loading

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.03     10.0±0.58ms     4.1 MB/sec    1.00      9.7±0.53ms     4.2 MB/sec
formatter/numpy/ctypeslib.py               1.03  1950.3±99.86µs     8.5 MB/sec    1.00  1893.9±104.22µs     8.8 MB/sec
formatter/numpy/globals.py                 1.00   209.2±20.82µs    14.1 MB/sec    1.02   213.7±15.38µs    13.8 MB/sec
formatter/pydantic/types.py                1.00      4.0±0.24ms     6.4 MB/sec    1.03      4.1±0.29ms     6.2 MB/sec
linter/all-rules/large/dataset.py          1.07     14.1±0.68ms     2.9 MB/sec    1.00     13.2±0.53ms     3.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.5±0.13ms     4.8 MB/sec    1.05      3.7±0.21ms     4.6 MB/sec
linter/all-rules/numpy/globals.py          1.04   511.2±31.88µs     5.8 MB/sec    1.00   490.1±31.16µs     6.0 MB/sec
linter/all-rules/pydantic/types.py         1.02      6.4±0.36ms     4.0 MB/sec    1.00      6.3±0.33ms     4.1 MB/sec
linter/default-rules/large/dataset.py      1.00      7.3±0.43ms     5.6 MB/sec    1.08      7.9±0.53ms     5.2 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1547.1±88.85µs    10.8 MB/sec    1.05  1618.5±96.76µs    10.3 MB/sec
linter/default-rules/numpy/globals.py      1.03   175.6±14.14µs    16.8 MB/sec    1.00   170.6±10.65µs    17.3 MB/sec
linter/default-rules/pydantic/types.py     1.01      3.3±0.20ms     7.7 MB/sec    1.00      3.3±0.18ms     7.7 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00     12.3±0.25ms     3.3 MB/sec    1.01     12.3±0.26ms     3.3 MB/sec
formatter/numpy/ctypeslib.py               1.01      2.4±0.11ms     7.0 MB/sec    1.00      2.4±0.07ms     7.0 MB/sec
formatter/numpy/globals.py                 1.00   257.6±13.14µs    11.5 MB/sec    1.02   262.8±19.17µs    11.2 MB/sec
formatter/pydantic/types.py                1.00      5.2±0.15ms     4.9 MB/sec    1.01      5.2±0.16ms     4.9 MB/sec
linter/all-rules/large/dataset.py          1.00     16.7±0.21ms     2.4 MB/sec    1.01     16.9±0.47ms     2.4 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.3±0.11ms     3.8 MB/sec    1.01      4.4±0.14ms     3.8 MB/sec
linter/all-rules/numpy/globals.py          1.00   533.5±17.76µs     5.5 MB/sec    1.00   532.3±17.79µs     5.5 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.5±0.17ms     3.4 MB/sec    1.00      7.5±0.14ms     3.4 MB/sec
linter/default-rules/large/dataset.py      1.00      9.2±0.21ms     4.4 MB/sec    1.01      9.3±0.21ms     4.4 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1861.9±36.01µs     8.9 MB/sec    1.00  1869.2±36.12µs     8.9 MB/sec
linter/default-rules/numpy/globals.py      1.00   209.9±11.59µs    14.1 MB/sec    1.00    210.3±6.65µs    14.0 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.0±0.08ms     6.4 MB/sec    1.00      4.0±0.09ms     6.4 MB/sec

MichaReiser
MichaReiser approved these changes Jul 31, 2023
View reviewed changes
konstin added 2 commits July 31, 2023 19:45
@konstin
Log configuration in ruff_dev
e0a9a06 
**Summary** This includes two changes:
 * Allow settings `-v` in `ruff_dev`, using the `ruff_cli` code
 * `debug!` which configuration strategy was used

This is a byproduct of debugging #6187.

**Test Plan** n/a
@konstin
windows
542b9ba
@konstin konstin force-pushed the config_logging_in_ruff_dev branch from 5d49c66 to 542b9ba Compare July 31, 2023 17:46
@konstin konstin enabled auto-merge (squash) July 31, 2023 17:47
@konstin konstin merged commit e52b636 into main Jul 31, 2023
@konstin konstin deleted the config_logging_in_ruff_dev branch July 31, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees

No one assigned

Labels

formatter Related to the formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@konstin @MichaReiser