Include decorators in Function and Class definition ranges#4467
Merged
MichaReiser merged 2 commits intomainfrom May 22, 2023
Merged
Include decorators in Function and Class definition ranges#4467MichaReiser merged 2 commits intomainfrom
Function and Class definition ranges#4467MichaReiser merged 2 commits intomainfrom
Conversation
Member
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Contributor
PR Check ResultsEcosystemℹ️ ecosystem check detected changes. (+55, -53, 0 error(s)) airflow (+31, -29)
- airflow/cli/commands/celery_command.py:116:13: A003 Class attribute `filter` is shadowing a Python builtin
+ airflow/cli/commands/celery_command.py:116:17: A003 Class attribute `filter` is shadowing a Python builtin
- airflow/configuration.py:1681:1: A001 Variable `set` is shadowing a Python builtin
+ airflow/configuration.py:1681:5: A001 Variable `set` is shadowing a Python builtin
+ airflow/example_dags/example_sensor_decorator.py:21:1: I001 [*] Import block is un-sorted or un-formatted
+ airflow/example_dags/tutorial_taskflow_api.py:18:1: I001 [*] Import block is un-sorted or un-formatted
- airflow/models/errors.py:26:1: A001 Variable `ImportError` is shadowing a Python builtin
+ airflow/models/errors.py:26:7: A001 Variable `ImportError` is shadowing a Python builtin
- airflow/models/variable.py:154:5: A003 Class attribute `set` is shadowing a Python builtin
+ airflow/models/variable.py:154:9: A003 Class attribute `set` is shadowing a Python builtin
- airflow/models/xcom.py:137:5: A003 Class attribute `set` is shadowing a Python builtin
+ airflow/models/xcom.py:137:9: A003 Class attribute `set` is shadowing a Python builtin
- airflow/models/xcom.py:166:5: A003 Class attribute `set` is shadowing a Python builtin
+ airflow/models/xcom.py:166:9: A003 Class attribute `set` is shadowing a Python builtin
- airflow/models/xcom.py:182:5: A003 Class attribute `set` is shadowing a Python builtin
+ airflow/models/xcom.py:182:9: A003 Class attribute `set` is shadowing a Python builtin
- airflow/models/xcom_arg.py:178:5: A003 Class attribute `map` is shadowing a Python builtin
+ airflow/models/xcom_arg.py:178:9: A003 Class attribute `map` is shadowing a Python builtin
- airflow/models/xcom_arg.py:181:5: A003 Class attribute `zip` is shadowing a Python builtin
+ airflow/models/xcom_arg.py:181:9: A003 Class attribute `zip` is shadowing a Python builtin
- airflow/models/xcom_arg.py:302:5: A003 Class attribute `map` is shadowing a Python builtin
+ airflow/models/xcom_arg.py:302:9: A003 Class attribute `map` is shadowing a Python builtin
- airflow/models/xcom_arg.py:307:5: A003 Class attribute `zip` is shadowing a Python builtin
+ airflow/models/xcom_arg.py:307:9: A003 Class attribute `zip` is shadowing a Python builtin
- airflow/models/xcom_arg.py:450:5: A003 Class attribute `map` is shadowing a Python builtin
+ airflow/models/xcom_arg.py:450:9: A003 Class attribute `map` is shadowing a Python builtin
- airflow/providers/google/cloud/hooks/bigquery.py:2793:5: A003 Class attribute `next` is shadowing a Python builtin
+ airflow/providers/google/cloud/hooks/bigquery.py:2793:9: A003 Class attribute `next` is shadowing a Python builtin
- airflow/providers/google/cloud/hooks/gcs.py:699:5: A003 Class attribute `list` is shadowing a Python builtin
+ airflow/providers/google/cloud/hooks/gcs.py:699:9: A003 Class attribute `list` is shadowing a Python builtin
- airflow/providers/microsoft/azure/hooks/data_lake.py:216:5: A003 Class attribute `list` is shadowing a Python builtin
+ airflow/providers/microsoft/azure/hooks/data_lake.py:216:9: A003 Class attribute `list` is shadowing a Python builtin
- airflow/utils/file.py:46:5: A003 Class attribute `compile` is shadowing a Python builtin
+ airflow/utils/file.py:46:9: A003 Class attribute `compile` is shadowing a Python builtin
- airflow/utils/file.py:64:5: A003 Class attribute `compile` is shadowing a Python builtin
+ airflow/utils/file.py:64:9: A003 Class attribute `compile` is shadowing a Python builtin
- airflow/utils/file.py:92:5: A003 Class attribute `compile` is shadowing a Python builtin
+ airflow/utils/file.py:92:9: A003 Class attribute `compile` is shadowing a Python builtin
- airflow/utils/log/colored_log.py:95:5: A003 Class attribute `format` is shadowing a Python builtin
+ airflow/utils/log/colored_log.py:95:9: A003 Class attribute `format` is shadowing a Python builtin
- airflow/utils/log/json_formatter.py:42:5: A003 Class attribute `format` is shadowing a Python builtin
+ airflow/utils/log/json_formatter.py:42:9: A003 Class attribute `format` is shadowing a Python builtin
- airflow/utils/log/secrets_masker.py:189:5: A003 Class attribute `filter` is shadowing a Python builtin
+ airflow/utils/log/secrets_masker.py:189:9: A003 Class attribute `filter` is shadowing a Python builtin
- airflow/utils/log/trigger_handler.py:41:5: A003 Class attribute `filter` is shadowing a Python builtin
+ airflow/utils/log/trigger_handler.py:41:9: A003 Class attribute `filter` is shadowing a Python builtin
- airflow/utils/log/trigger_handler.py:64:5: A003 Class attribute `filter` is shadowing a Python builtin
+ airflow/utils/log/trigger_handler.py:64:9: A003 Class attribute `filter` is shadowing a Python builtin
- airflow/www/views.py:4721:5: A003 Class attribute `list` is shadowing a Python builtin
+ airflow/www/views.py:4721:9: A003 Class attribute `list` is shadowing a Python builtin
- airflow/www/views.py:4773:5: A003 Class attribute `list` is shadowing a Python builtin
+ airflow/www/views.py:4773:9: A003 Class attribute `list` is shadowing a Python builtin
- airflow/www/views.py:5776:5: A003 Class attribute `list` is shadowing a Python builtin
+ airflow/www/views.py:5776:9: A003 Class attribute `list` is shadowing a Python builtin
- dev/breeze/src/airflow_breeze/commands/developer_commands.py:581:1: A001 Variable `exec` is shadowing a Python builtin
+ dev/breeze/src/airflow_breeze/commands/developer_commands.py:581:5: A001 Variable `exec` is shadowing a Python builtin
- tests/providers/openlineage/extractors/test_python_extractor.py:52:1: A001 Variable `callable` is shadowing a Python builtin
+ tests/providers/openlineage/extractors/test_python_extractor.py:52:5: A001 Variable `callable` is shadowing a Python builtin
+ tests/providers/openlineage/plugins/test_utils.py:121:11: A001 Variable `NotImplemented` is shadowing a Python builtin
- tests/providers/openlineage/plugins/test_utils.py:121:5: A001 Variable `NotImplemented` is shadowing a Python builtinbokeh (+17, -17)
- src/bokeh/__init__.py:62:1: A001 Variable `license` is shadowing a Python builtin
+ src/bokeh/__init__.py:62:5: A001 Variable `license` is shadowing a Python builtin
- src/bokeh/application/application.py:318:5: A003 Class attribute `id` is shadowing a Python builtin
+ src/bokeh/application/application.py:318:9: A003 Class attribute `id` is shadowing a Python builtin
- src/bokeh/client/session.py:365:5: A003 Class attribute `id` is shadowing a Python builtin
+ src/bokeh/client/session.py:365:9: A003 Class attribute `id` is shadowing a Python builtin
- src/bokeh/core/property/bases.py:130:5: A003 Class attribute `help` is shadowing a Python builtin
+ src/bokeh/core/property/bases.py:130:9: A003 Class attribute `help` is shadowing a Python builtin
- src/bokeh/core/validation/issue.py:49:1: A001 Variable `Warning` is shadowing a Python builtin
+ src/bokeh/core/validation/issue.py:49:7: A001 Variable `Warning` is shadowing a Python builtin
- src/bokeh/core/validation/issue.py:66:5: A003 Class attribute `all` is shadowing a Python builtin
+ src/bokeh/core/validation/issue.py:66:9: A003 Class attribute `all` is shadowing a Python builtin
- src/bokeh/core/validation/issue.py:87:5: A003 Class attribute `all` is shadowing a Python builtin
+ src/bokeh/core/validation/issue.py:87:9: A003 Class attribute `all` is shadowing a Python builtin
- src/bokeh/model/model.py:128:5: A003 Class attribute `id` is shadowing a Python builtin
+ src/bokeh/model/model.py:128:9: A003 Class attribute `id` is shadowing a Python builtin
- src/bokeh/plotting/glyph_api.py:413:5: A003 Class attribute `hex` is shadowing a Python builtin
+ src/bokeh/plotting/glyph_api.py:413:9: A003 Class attribute `hex` is shadowing a Python builtin
- src/bokeh/server/callbacks.py:74:5: A003 Class attribute `id` is shadowing a Python builtin
+ src/bokeh/server/callbacks.py:74:9: A003 Class attribute `id` is shadowing a Python builtin
- src/bokeh/server/session.py:159:5: A003 Class attribute `id` is shadowing a Python builtin
+ src/bokeh/server/session.py:159:9: A003 Class attribute `id` is shadowing a Python builtin
- src/bokeh/server/views/ws.py:125:5: A003 Class attribute `open` is shadowing a Python builtin
+ src/bokeh/server/views/ws.py:125:9: A003 Class attribute `open` is shadowing a Python builtin
- src/bokeh/settings.py:484:5: A003 Class attribute `help` is shadowing a Python builtin
+ src/bokeh/settings.py:484:9: A003 Class attribute `help` is shadowing a Python builtin
- src/bokeh/util/browser.py:54:5: A003 Class attribute `open` is shadowing a Python builtin
+ src/bokeh/util/browser.py:54:9: A003 Class attribute `open` is shadowing a Python builtin
- src/bokeh/util/browser.py:61:5: A003 Class attribute `open` is shadowing a Python builtin
+ src/bokeh/util/browser.py:61:9: A003 Class attribute `open` is shadowing a Python builtin
- src/typings/selenium/webdriver/remote/webdriver.pyi:29:5: A003 Class attribute `quit` is shadowing a Python builtin
+ src/typings/selenium/webdriver/remote/webdriver.pyi:29:9: A003 Class attribute `quit` is shadowing a Python builtin
- tests/unit/bokeh/util/test_browser.py:38:5: A003 Class attribute `open` is shadowing a Python builtin
+ tests/unit/bokeh/util/test_browser.py:38:9: A003 Class attribute `open` is shadowing a Python builtinzulip (+7, -7)
- zerver/lib/bot_lib.py:152:5: A003 Class attribute `quit` is shadowing a Python builtin
+ zerver/lib/bot_lib.py:152:9: A003 Class attribute `quit` is shadowing a Python builtin
- zerver/lib/logging_util.py:110:5: A003 Class attribute `filter` is shadowing a Python builtin
+ zerver/lib/logging_util.py:110:9: A003 Class attribute `filter` is shadowing a Python builtin
- zerver/lib/logging_util.py:115:5: A003 Class attribute `filter` is shadowing a Python builtin
+ zerver/lib/logging_util.py:115:9: A003 Class attribute `filter` is shadowing a Python builtin
- zerver/lib/logging_util.py:120:5: A003 Class attribute `filter` is shadowing a Python builtin
+ zerver/lib/logging_util.py:120:9: A003 Class attribute `filter` is shadowing a Python builtin
- zerver/lib/logging_util.py:200:5: A003 Class attribute `format` is shadowing a Python builtin
+ zerver/lib/logging_util.py:200:9: A003 Class attribute `format` is shadowing a Python builtin
- zerver/lib/logging_util.py:224:5: A003 Class attribute `format` is shadowing a Python builtin
+ zerver/lib/logging_util.py:224:9: A003 Class attribute `format` is shadowing a Python builtin
- zerver/lib/logging_util.py:65:5: A003 Class attribute `filter` is shadowing a Python builtin
+ zerver/lib/logging_util.py:65:9: A003 Class attribute `filter` is shadowing a Python builtin
BenchmarkLinuxWindows |
| @@ -1107,21 +1107,40 @@ pub fn match_parens(start: TextSize, locator: &Locator) -> Option<TextRange> { | |||
| /// Specifically, this method returns the range of a function or class name, | |||
| /// rather than that of the entire function or class body. | |||
| pub fn identifier_range(stmt: &Stmt, locator: &Locator) -> TextRange { | |||
Member
There was a problem hiding this comment.
Thanks, this is what I was going to point out :)
charliermarsh
approved these changes
May 19, 2023
charliermarsh
approved these changes
May 19, 2023
MichaReiser
force-pushed
the
include-decorator-range-in-function-and-class-def
branch
from
c7fd2b5 to
a9247fd
Compare
Member
Author
|
I need to look into the ecosystem changes. They look suspicious |
MichaReiser
force-pushed
the
include-decorator-range-in-function-and-class-def
branch
from
a9247fd to
9a1fb0c
Compare
MichaReiser
force-pushed
the
include-decorator-range-in-function-and-class-def
branch
2 times, most recently
from
ba09a05 to
f81b0a7
Compare
MichaReiser
force-pushed
the
include-decorator-range-in-function-and-class-def
branch
from
f81b0a7 to
fc7502b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See RustPython/Parser#49