Skip to content

Comments

Add Applicability to Fix#4303

Merged
MichaReiser merged 11 commits intoastral-sh:mainfrom
zanieb:internal/4183
May 10, 2023
Merged

Add Applicability to Fix#4303
MichaReiser merged 11 commits intoastral-sh:mainfrom
zanieb:internal/4183

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented May 9, 2023

Adds Applicability levels to Fix with corresponding factory methods and deprecates the unspecified fix methods.

Updates Diff output to include "Fix", "Suggested fix", and "Possible fix" depending on the applicability.

Closes #4183

zanieb
zanieb commented May 9, 2023
View reviewed changes
zanieb
zanieb commented May 9, 2023
View reviewed changes
@zanieb zanieb force-pushed the internal/4183 branch 2 times, most recently from b51fa31 to f5fc16d Compare May 9, 2023 06:21
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023 •
edited
Loading

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     16.7±0.16ms     2.4 MB/sec    1.00     16.8±0.13ms     2.4 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      4.0±0.03ms     4.2 MB/sec    1.00      4.0±0.03ms     4.2 MB/sec
linter/all-rules/numpy/globals.py          1.00    490.9±2.78µs     6.0 MB/sec    1.00    491.2±8.12µs     6.0 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.0±0.04ms     3.7 MB/sec    1.00      6.9±0.16ms     3.7 MB/sec
linter/default-rules/large/dataset.py      1.02      8.3±0.06ms     4.9 MB/sec    1.00      8.1±0.05ms     5.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.02   1775.6±9.02µs     9.4 MB/sec    1.00  1740.3±12.96µs     9.6 MB/sec
linter/default-rules/numpy/globals.py      1.02    197.8±2.36µs    14.9 MB/sec    1.00    193.6±4.55µs    15.2 MB/sec
linter/default-rules/pydantic/types.py     1.02      3.7±0.01ms     6.9 MB/sec    1.00      3.6±0.03ms     7.0 MB/sec
parser/large/dataset.py                    1.00      6.6±0.03ms     6.2 MB/sec    1.10      7.3±0.05ms     5.6 MB/sec
parser/numpy/ctypeslib.py                  1.00   1287.3±3.48µs    12.9 MB/sec    1.09   1397.3±6.70µs    11.9 MB/sec
parser/numpy/globals.py                    1.00    130.4±0.40µs    22.6 MB/sec    1.06    138.8±1.41µs    21.3 MB/sec
parser/pydantic/types.py                   1.00      2.8±0.01ms     9.1 MB/sec    1.09      3.1±0.02ms     8.4 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     18.2±0.66ms     2.2 MB/sec    1.01     18.5±0.72ms     2.2 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      4.8±0.26ms     3.5 MB/sec    1.00      4.7±0.30ms     3.5 MB/sec
linter/all-rules/numpy/globals.py          1.00   544.0±24.42µs     5.4 MB/sec    1.02   552.6±25.87µs     5.3 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.7±0.37ms     3.3 MB/sec    1.00      7.7±0.35ms     3.3 MB/sec
linter/default-rules/large/dataset.py      1.00      9.3±0.51ms     4.4 MB/sec    1.01      9.4±0.33ms     4.3 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1938.4±78.28µs     8.6 MB/sec    1.02  1980.3±79.16µs     8.4 MB/sec
linter/default-rules/numpy/globals.py      1.00   232.7±15.46µs    12.7 MB/sec    1.05   244.3±30.32µs    12.1 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.1±0.26ms     6.2 MB/sec    1.03      4.2±0.24ms     6.0 MB/sec
parser/large/dataset.py                    1.00      7.8±0.32ms     5.2 MB/sec    1.02      8.0±0.28ms     5.1 MB/sec
parser/numpy/ctypeslib.py                  1.00  1500.9±78.75µs    11.1 MB/sec    1.03  1542.4±71.67µs    10.8 MB/sec
parser/numpy/globals.py                    1.00   150.6±10.53µs    19.6 MB/sec    1.04    156.2±9.08µs    18.9 MB/sec
parser/pydantic/types.py                   1.00      3.4±0.22ms     7.5 MB/sec    1.02      3.4±0.14ms     7.4 MB/sec

MichaReiser
MichaReiser approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! I hope adding all the allow(deprecated) wasn't too much pain?

@MichaReiser MichaReiser added the internal An internal refactor or improvement label May 9, 2023
@zanieb zanieb marked this pull request as ready for review May 9, 2023 18:25
@zanieb zanieb mentioned this pull request May 9, 2023
Closed
@MichaReiser MichaReiser merged commit cf7aa26 into astral-sh:main May 10, 2023
@zanieb zanieb mentioned this pull request May 14, 2023
Closed
@zanieb zanieb mentioned this pull request Jun 14, 2023
Closed
@zanieb zanieb mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees

No one assigned

Labels

internal An internal refactor or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Applicability to Fix

2 participants

@zanieb @MichaReiser