Establish rule naming convention & disallow certain rule names#2712
Merged
charliermarsh merged 7 commits intoastral-sh:mainfrom Feb 10, 2023
Merged
Establish rule naming convention & disallow certain rule names#2712charliermarsh merged 7 commits intoastral-sh:mainfrom
charliermarsh merged 7 commits intoastral-sh:mainfrom
Conversation
7 tasks
not-my-profile
force-pushed
the
disallowed-rule-names
branch
from
5116e05 to
5e3ba41
Compare
Member
|
This is great! Thank you @not-my-profile. |
Member
|
Can I squash this to get rid of the intermediary commits (like |
not-my-profile
force-pushed
the
disallowed-rule-names
branch
from
5e3ba41 to
4d32238
Compare
Contributor
Author
|
Rebased the If you'd resolve #2714, I could also rename the use-* rules ... or we could do that in a followup PR, whatever you prefer. |
Member
|
Let's do it in a follow-up, I'll try to resolve #2714 today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1773.
I would have also disallowed rule names starting with use-* but that is currently blocked by #2714.