Make unused variable pattern configurable#265
Merged
charliermarsh merged 16 commits intoastral-sh:mainfrom Sep 24, 2022
Merged
Conversation
harupy
commented
Sep 24, 2022
harupy
commented
Sep 24, 2022
harupy
commented
Sep 24, 2022
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
harupy
force-pushed
the
dummy_variable_rgx
branch
from
5e24b81 to
ef860bb
Compare
harupy
force-pushed
the
dummy_variable_rgx
branch
from
ef860bb to
5988f31
Compare
src/settings.rs
Outdated
| ] | ||
| }); | ||
|
|
||
| static DEFAULT_DUMMY_VARIABLE_RGX: Lazy<Regex> = Lazy::new(|| Regex::new("^_$").unwrap()); |
Member
There was a problem hiding this comment.
Should we make this _+$|(_[a-zA-Z0-9_]*[a-zA-Z0-9]+?$)|dummy|^ignored_|^unused_ to match Pylint?
Member
There was a problem hiding this comment.
(Will make this change then merge.)
Contributor
Author
There was a problem hiding this comment.
Yes, that sounds good to me :)
Member
There was a problem hiding this comment.
(A went for something in-between -- I think dummy and ignored and unused are a bit odd as defaults.)
Member
|
Looks great! |
snowsignal
pushed a commit
that referenced
this pull request
Apr 29, 2024
Add missing error codes, use doc comments for all of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #134.