[eradicate] Avoid flagging ruff:ignore comments as code (ERA001)#25537
Merged
Conversation
Summary -- Fixes #25535 by treating `ruff:ignore` comments in the same way as `ruff:enable` and `ruff:disable` comments. Test Plan -- New tests based on the issue
ntBre
added
bug
somewhat incredibly, this is also a valid annotation
|
Contributor
Author
|
I started wondering if we needed a fix like #25414 for |
MichaReiser
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #25535 by treating
ruff:ignoreandruff:file-ignorecomments in the same way asruff:enableandruff:disablecomments.Test Plan
New tests based on the issue