[pyupgrade] Avoid converting format calls with more kinds of side effects (UP032)#25484
Merged
Merged
Conversation
|
ntBre
changed the title
pyupgrade] Don't convert repeated args with non-call side effects (UP032)
ntBre
added
bug
ntBre
approved these changes
Jun 1, 2026
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thank you! I had a couple of minor suggestions that I'd like to get your thoughts on, but this looks reasonable to me.
ntBre
approved these changes
Jun 2, 2026
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks! I pushed a quick simplification now that we're not using the Checker again, but this otherwise still looks great.
ntBre
changed the title
pyupgrade] Don't convert repeated args with non-call side effects (UP032)pyupgrade] Avoid converting format calls with more kinds of side effects (UP032)
ntBre
added
rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes part of #15874: UP032 unsoundly converted str.format calls that repeat a side-effecting argument. The check only
caught calls, so a repeated d[k] or walrus slipped through. Switch it to contains_effect.
Test Plan
New mdtest at crates/ruff_linter/resources/mdtest/pyupgrade/f-string.md.