Fix Markdown closing fence handling#25310
Merged
MichaReiser merged 4 commits intoMay 22, 2026
Merged
Conversation
MichaReiser
reviewed
May 22, 2026
| .take_while(|&&byte| byte == fence_byte) | ||
| .count(); | ||
|
|
||
| fence_len >= opening_fence.len() && line[fence_len..].chars().all(is_python_whitespace) |
Member
There was a problem hiding this comment.
Can you say more about why you use is_python_whitespace here over char::is_whitespace? E.g. is_python_whitespace also includes form feeds, which I think is incorrect here
MichaReiser
added
bug
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
Co-authored-by: Micha Reiser <[email protected]>
anishgirianish
pushed a commit
to anishgirianish/ruff
that referenced
this pull request
May 28, 2026
Co-authored-by: Micha Reiser <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #25309.
Test
cargo test -p ruff_markdownuvx prek run --files crates/ruff_markdown/src/lib.rscargo run --bin ruff -- format --preview --isolated --stdin-filename repro.md -