Skip to content

Colorize ruff check 'All checks passed'#25085

Merged
ntBre merged 1 commit into
astral-sh:mainfrom
Hrk84ya:fix/ruff-check-success-color
May 11, 2026
Merged

Colorize ruff check 'All checks passed'#25085
ntBre merged 1 commit into
astral-sh:mainfrom
Hrk84ya:fix/ruff-check-success-color

Conversation

@Hrk84ya
Copy link
Copy Markdown

@Hrk84ya Hrk84ya commented May 10, 2026

Apply .green().bold() styling to the 'All checks passed!' message in ruff check output, matching the styling already used by ty. This makes the success message visually consistent across both tools.

Closes #24840

Apply .green().bold() styling to the 'All checks passed!' message in
ruff check output, matching the styling already used by ty. This makes
the success message visually consistent across both tools.

Closes astral-sh#24840
Copilot AI review requested due to automatic review settings May 10, 2026 06:18
@astral-sh-bot astral-sh-bot Bot requested a review from ntBre May 10, 2026 06:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates ruff check’s success summary styling so the “All checks passed!” message uses the same green + bold formatting as ty, improving visual consistency across the tools.

Changes:

  • Style the zero-diagnostics success message with .green().bold() in the text summary output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@astral-sh-bot
Copy link
Copy Markdown

astral-sh-bot Bot commented May 10, 2026

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser changed the title [ty] Make ruff check 'All checks passed!' color consistent with ty Colorize ruff check 'All checks passed' May 11, 2026
@MichaReiser MichaReiser added the cli Related to the command-line interface label May 11, 2026
Copy link
Copy Markdown
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ntBre ntBre merged commit 0998ca0 into astral-sh:main May 11, 2026
73 of 76 checks passed
thejchap pushed a commit to thejchap/ruff that referenced this pull request May 23, 2026
Apply .green().bold() styling to the 'All checks passed!' message in
ruff check output, matching the styling already used by ty. This makes
the success message visually consistent across both tools.

Closes astral-sh#24840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Related to the command-line interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can the ruff color "All checks passed!" be made consistent with ty please

4 participants