[ty] Add error context for TypedDict assignments#24790
Merged
Conversation
sharkdp
added
ty
sharkdp
commented
Apr 22, 2026
| ```toml | ||
| [environment] | ||
| python-version = "3.12" | ||
| python-version = "3.13" |
Contributor
Author
There was a problem hiding this comment.
For typing.ReadOnly
sharkdp
force-pushed
the
david/typeddict-context
branch
from
11d34f4 to
2348b2a
Compare
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 87.94%. The percentage of expected errors that received a diagnostic held steady at 83.36%. The number of fully passing files held steady at 79/133. |
Memory usage reportMemory usage unchanged ✅ |
|
sharkdp
requested review from
AlexWaygood,
carljm,
dcreager and
ibraheemdev
as code owners
AlexWaygood
reviewed
Apr 22, 2026
| | | | ||
| | Declared type | ||
| | | ||
| info: field "name" on TypedDict `Person` has type `str` which is not assignable to type `bytes` expected by TypedDict `Other` |
Member
There was a problem hiding this comment.
or maybe
Suggested change
| info: field "name" on TypedDict `Person` has type `str` which is not assignable to type `bytes` expected by TypedDict `Other` | |
| info: Incompatible types for the `name` field | |
| info: └── `str` is not assignable to `bytes` |
?
Contributor
Author
There was a problem hiding this comment.
no, that would contradict the general structure. If str and bytes were more complex types, we would show a subtree, but we don't do that for basic types.
Member
There was a problem hiding this comment.
hmm, okay. it just about fits onto a single line on a terminal screen if I have the terminal full-screen:
but not at all if I'm split-screening (but then, I'm sure that also applies for other diagnostic messages we show -- including, in this case, the summary message:
AlexWaygood
approved these changes
Apr 22, 2026
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add error context for
TypedDicttoTypedDictassignmentsTest Plan
Adapted and new Markdown tests.