Revert preview changes to displayed diagnostic severity in LSP#24789
Merged
dylwil3 merged 1 commit intoastral-sh:mainfrom Apr 22, 2026
Merged
Revert preview changes to displayed diagnostic severity in LSP#24789dylwil3 merged 1 commit intoastral-sh:mainfrom
dylwil3 merged 1 commit intoastral-sh:mainfrom
Conversation
dylwil3
added
preview
|
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it may take a little more time to support user-configured severities, it makes sense to revert this change for now as it is disruptive to users and there is no workaround.
(I don't think it's necessary to change the preview behavior in the CLI since both the displayed color and the exit-code behavior is unchanged.)
Closes #24069
Screenshots
Before:
After:
