Skip to content

[ruff] Ignore RUF029 when function is decorated with asynccontextmanager#24642

Merged
ntBre merged 2 commits into
astral-sh:mainfrom
augustelalande:asynccontextmanager
Apr 15, 2026
Merged

[ruff] Ignore RUF029 when function is decorated with asynccontextmanager#24642
ntBre merged 2 commits into
astral-sh:mainfrom
augustelalande:asynccontextmanager

Conversation

@augustelalande
Copy link
Copy Markdown
Contributor

@augustelalande augustelalande commented Apr 14, 2026

Summary

Ignore RUF029 when function is decorated with asynccontextmanager. For example I ran across this when working with FastAPI lifespan https://fastapi.tiangolo.com/advanced/events/

@asynccontextmanager
async def lifespan(app: FastAPI):
    # Load the ML model
    ml_models["answer_to_everything"] = fake_answer_to_everything_ml_model
    yield
    # Clean up the ML models and release the resources
    ml_models.clear()


app = FastAPI(lifespan=lifespan)

Test Plan

Test fixture added

@astral-sh-bot astral-sh-bot Bot requested a review from amyreese April 14, 2026 19:20
@astral-sh-bot
Copy link
Copy Markdown

astral-sh-bot Bot commented Apr 14, 2026

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+4 -10 violations, +0 -0 fixes in 2 projects; 54 projects unchanged)

langchain-ai/langchain (+0 -10 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

- libs/core/tests/unit_tests/callbacks/test_async_callback_manager.py:89:15: RUF029 Function `set_counter_var` is declared `async`, but doesn't `await` or use `async` features.
- libs/langchain_v1/tests/unit_tests/agents/conftest_checkpointer.py:15:11: RUF029 Function `_checkpointer_memory_aio` is declared `async`, but doesn't `await` or use `async` features.
- libs/langchain_v1/tests/unit_tests/agents/conftest_checkpointer.py:45:11: RUF029 Function `_checkpointer_sqlite_aio` is declared `async`, but doesn't `await` or use `async` features.
- libs/langchain_v1/tests/unit_tests/agents/conftest_checkpointer.py:51:11: RUF029 Function `_checkpointer_postgres_aio` is declared `async`, but doesn't `await` or use `async` features.
- libs/langchain_v1/tests/unit_tests/agents/conftest_checkpointer.py:57:11: RUF029 Function `_checkpointer_postgres_aio_pipe` is declared `async`, but doesn't `await` or use `async` features.
- libs/langchain_v1/tests/unit_tests/agents/conftest_checkpointer.py:63:11: RUF029 Function `_checkpointer_postgres_aio_pool` is declared `async`, but doesn't `await` or use `async` features.
- libs/langchain_v1/tests/unit_tests/agents/conftest_store.py:15:11: RUF029 Function `_store_memory_aio` is declared `async`, but doesn't `await` or use `async` features.
- libs/langchain_v1/tests/unit_tests/agents/conftest_store.py:43:11: RUF029 Function `_store_postgres_aio` is declared `async`, but doesn't `await` or use `async` features.
- libs/langchain_v1/tests/unit_tests/agents/conftest_store.py:50:11: RUF029 Function `_store_postgres_aio_pipe` is declared `async`, but doesn't `await` or use `async` features.
- libs/langchain_v1/tests/unit_tests/agents/conftest_store.py:57:11: RUF029 Function `_store_postgres_aio_pool` is declared `async`, but doesn't `await` or use `async` features.

reflex-dev/reflex (+4 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

+ tests/integration/test_lifespan.py:34:53: RUF100 [*] Unused `noqa` directive (unused: `RUF029`)
+ tests/units/istate/test_proxy.py:56:64: RUF100 [*] Unused `noqa` directive (unused: `RUF029`)
+ tests/units/mock_redis.py:187:26: RUF100 [*] Unused `noqa` directive (unused: `RUF029`)
+ tests/units/utils/test_token_manager.py:250:30: RUF100 [*] Unused `noqa` directive (unused: `RUF029`)

Changes by rule (2 rules affected)

code total + violation - violation + fix - fix
RUF029 10 0 10 0 0
RUF100 4 4 0 0 0

@ntBre ntBre added rule Implementing or modifying a lint rule preview Related to preview mode features labels Apr 15, 2026
ntBre
ntBre approved these changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ntBre ntBre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thank you!

Comment thread crates/ruff_linter/src/rules/ruff/rules/unused_async.rs
fn is_async_context_manager(function_def: &ast::StmtFunctionDef, semantic: &SemanticModel) -> bool {
function_def.decorator_list.iter().any(|decorator| {
semantic
.resolve_qualified_name(&decorator.expression)
Copy link
Copy Markdown
Contributor

@ntBre ntBre Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that we usually use map_callable on decorators to support the case where they're called, but this doesn't seem to be supported for asynccontextmanager:

>>> from contextlib import asynccontextmanager
>>> @asynccontextmanager()
... def foo(): ...
...
Traceback (most recent call last):
  File "<python-input-1>", line 1, in <module>
    @asynccontextmanager()
     ~~~~~~~~~~~~~~~~~~~^^
TypeError: asynccontextmanager() missing 1 required positional argument: 'func'

so this seems correct in this case.

@ntBre ntBre changed the title [ruff] Ignore RUF029 when function is decorated with asynccontextmanager [ruff] Ignore RUF029 when function is decorated with asynccontextmanager Apr 15, 2026
@ntBre ntBre merged commit 7d2d447 into astral-sh:main Apr 15, 2026
44 checks passed
@augustelalande augustelalande deleted the asynccontextmanager branch April 15, 2026 16:58
@BrewTestBot BrewTestBot mentioned this pull request Apr 16, 2026
Merged
This was referenced Apr 27, 2026
Merged
Draft
nicopauss pushed a commit to Intersec/lib-common that referenced this pull request Jun 4, 2026
@renovate-bot
chore(deps): update dependency ruff to v0.15.12 (2024.6)
85681d7 
##### [\`v0.15.12\`](https://github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#01512)

Released on 2026-04-24.

##### Preview features

- Implement `#ruff:file-ignore` file-level suppressions ([#23599](astral-sh/ruff#23599))
- Implement `#ruff:ignore` logical-line suppressions ([#23404](astral-sh/ruff#23404))
- Revert preview changes to displayed diagnostic severity in LSP ([#24789](astral-sh/ruff#24789))
- \[`airflow`] Implement `task-branch-as-short-circuit` (`AIR004`) ([#23579](astral-sh/ruff#23579))
- \[`flake8-bugbear`] Fix `break`/`continue` handling in `loop-iterator-mutation` (`B909`) ([#24440](astral-sh/ruff#24440))
- \[`pylint`] Fix `PLC2701` for type parameter scopes ([#24576](astral-sh/ruff#24576))

##### Rule changes

- \[`pandas-vet`] Suggest `.array` as well in `PD011` ([#24805](astral-sh/ruff#24805))

##### CLI

- Respect default Unix permissions for cache files ([#24794](astral-sh/ruff#24794))

##### Documentation

- \[`pylint`] Fix `PLR0124` description not to claim self-comparison always returns the same value ([#24749](astral-sh/ruff#24749))
- \[`pyupgrade`] Expand docs on reusable `TypeVar`s and scoping (`UP046`) ([#24153](astral-sh/ruff#24153))
- Improve rules table accessibility ([#24711](astral-sh/ruff#24711))

##### Contributors

- [@dylwil3](https://github.com/dylwil3)
- [@AlexWaygood](https://github.com/AlexWaygood)
- [@woodruffw](https://github.com/woodruffw)
- [@avasis-ai](https://github.com/avasis-ai)
- [@Dev-iL](https://github.com/Dev-iL)
- [@denyszhak](https://github.com/denyszhak)
- [@ShipItAndPray](https://github.com/ShipItAndPray)
- [@anishgirianish](https://github.com/anishgirianish)
- [@augustelalande](https://github.com/augustelalande)
- [@amyreese](https://github.com/amyreese)
- [@majiayu000](https://github.com/majiayu000)
##### [\`v0.15.11\`](https://github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#01511)

Released on 2026-04-16.

##### Preview features

- \[`ruff`] Ignore `RUF029` when function is decorated with `asynccontextmanager` ([#24642](astral-sh/ruff#24642))
- \[`airflow`] Implement `airflow-xcom-pull-in-template-string` (`AIR201`) ([#23583](astral-sh/ruff#23583))
- \[`flake8-bandit`] Fix `S103` false positives and negatives in mask analysis ([#24424](astral-sh/ruff#24424))

##### Bug fixes

- \[`flake8-async`] Omit overridden methods for `ASYNC109` ([#24648](astral-sh/ruff#24648))

##### Documentation

- \[`flake8-async`] Add override mention to `ASYNC109` docs ([#24666](astral-sh/ruff#24666))
- Update Neovim config examples to use `vim.lsp.config` ([#24577](astral-sh/ruff#24577))

##### Contributors

- [@augustelalande](https://github.com/augustelalande)
- [@anishgirianish](https://github.com/anishgirianish)
- [@benberryallwood](https://github.com/benberryallwood)
- [@charliermarsh](https://github.com/charliermarsh)
- [@Dev-iL](https://github.com/Dev-iL)

Renovate-Branch: renovate/2024.6-ruff-0.15.x
Change-Id: I2c5de44f14ce3133db71161eae18c7b43f7ba09b
Priv-Id: 9c1a7f10043a2db2338a90de9a62a4d7989df14d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntBre ntBre ntBre approved these changes

@amyreese amyreese Awaiting requested review from amyreese

Assignees

@amyreese amyreese

Labels

preview Related to preview mode features rule Implementing or modifying a lint rule

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@augustelalande @ntBre @amyreese