[ty] Enable pull-diagnostics by default in E2E tests#24516
Merged
MichaReiser merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
dhruvmanila
approved these changes
Apr 9, 2026
Member
dhruvmanila
left a comment
dhruvmanila
left a comment
There was a problem hiding this comment.
Looks reasonable, thanks!
MichaReiser
force-pushed
the
micha/e2e-pull-diagnostics
branch
from
0bf35e3 to
6170ecd
Compare
ibraheemdev
pushed a commit
that referenced
this pull request
Apr 15, 2026
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publish diagnostics are a bit annoying in end to end tests because the test harness requires tests to consume all notifications.
That's why many tests awaited the publish diagnostics but then did nothing with it, resulting in unnecessary boilerplate in our tests.
Many other tests called
enable_pull_diagnosticsso as that they don't have to deal with this.Given that most clients support pull diagnostics and since they're easier to work with in tests, I suggest we enable them by default in the
TestServerBuilder.Tests asserting the publish diagnostic workflow can disable pull diagnostic support by using
enable_pull_diagnostic(false).I think this helped discover a bug where ty sent a
publish_diagnosticnotification even for clients supporting pull diagnostics when removing a workspace folder.Test Plan
cargo test