[ty] calculate positive and negative narrowing constraints simultaneously#23551
Draft
mtshiba wants to merge 4 commits intoastral-sh:mainfrom
Draft
[ty] calculate positive and negative narrowing constraints simultaneously#23551mtshiba wants to merge 4 commits intoastral-sh:mainfrom
mtshiba wants to merge 4 commits intoastral-sh:mainfrom
Conversation
Typing conformance resultsNo changes detected ✅ |
|
Memory usage reportSummary
Significant changesClick to expand detailed breakdownprefect
sphinx
trio
flake8
|
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
unsupported-operator |
87 | 0 | 0 |
unresolved-attribute |
5 | 0 | 0 |
invalid-argument-type |
2 | 0 | 0 |
| Total | 94 | 0 | 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From #23201
Currently,
infer_narrowing_constraintcalls two separate salsa query functions, one for positive and one for negative.However, due to the structure of control flow analysis, both functions are often called simultaneously. In this case, almost identical calculations are performed twice while scanning the predicate node. Therefore, calculating the positive and negative narrowing constraints for a given predicate simultaneously can improve performance and reduce memory costs.
Test Plan
No-op