[ty] Avoid dictionary key narrowing for multi-target assignments#23523
Merged
ibraheemdev merged 1 commit intomainfrom Feb 24, 2026
Merged
[ty] Avoid dictionary key narrowing for multi-target assignments#23523ibraheemdev merged 1 commit intomainfrom
ibraheemdev merged 1 commit intomainfrom
Conversation
ibraheemdev
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
Typing conformance resultsNo changes detected ✅ |
|
Memory usage reportMemory usage unchanged ✅ |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-await |
40 | 0 | 0 |
invalid-assignment |
4 | 0 | 0 |
unresolved-attribute |
2 | 2 | 0 |
unsupported-operator |
0 | 4 | 0 |
invalid-argument-type |
1 | 2 | 0 |
invalid-return-type |
1 | 0 | 0 |
| Total | 48 | 8 | 0 |
sharkdp
approved these changes
Feb 24, 2026
Contributor
sharkdp
left a comment
sharkdp
left a comment
There was a problem hiding this comment.
However, it looks like we do have internal support for associating multiple definitions with a single AST node, but we currently panic if it ever happens. I'm not sure if the assert is just enforcing our current behavior, or there's some other reason we avoid this?
I can't answer this question, but this looks like a good (intermediate) solution to avoid the panic. Thanks.
Member
Currently I think the only place where we associate multiple definitions with a single AST node is |
Member
Author
|
Going to merge the easy fix for now at least. |
Contributor
Originally we didn't allow this. Then we added support for it because it was necessary for So if you want to have a new node kind support multiple definitions, it just means you have to ensure that wherever type-inference accesses definitions for that node kind, it does not use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example below currently panics.
We attempt to synthesize places for
x["a"]andy["a"]and associate them with a definition for the key-value assignment. However, the definition is uniquely identified by the AST node for"a", causing a panic.This PR avoids narrowing for multi-target assignments. However, it looks like we do have internal support for associating multiple definitions with a single AST node, but we currently panic if it ever happens. I'm not sure if the assert is just enforcing our current behavior, or there's some other reason we avoid this?
Resolves astral-sh/ty#2866.