[ty] Improve diagnostics for subscriptions of non-generic types#23516
Merged
AlexWaygood merged 1 commit intomainfrom Feb 24, 2026
Merged
[ty] Improve diagnostics for subscriptions of non-generic types#23516AlexWaygood merged 1 commit intomainfrom
AlexWaygood merged 1 commit intomainfrom
Conversation
Typing conformance resultsNo changes detected ✅ |
|
Memory usage reportMemory usage unchanged ✅ |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
not-subscriptable |
0 | 0 | 462 |
unsupported-operator |
87 | 0 | 0 |
invalid-await |
40 | 0 | 0 |
unresolved-attribute |
5 | 0 | 0 |
invalid-argument-type |
2 | 0 | 0 |
invalid-return-type |
1 | 0 | 0 |
| Total | 135 | 0 | 462 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains some minor followups to #21840 to improve our diagnostics in a few places. I've had this patch hanging around locally for a while and can't remember exactly what I had thought there still was to do on it anymore... I think these are still worthwhile improvements, anyway!
Test Plan
Snapshots