Render sub-diagnostics in the GitHub output format#23455
Merged
Conversation
Typing conformance resultsNo changes detected ✅ |
|
Memory usage reportMemory usage unchanged ✅ |
|
AlexWaygood
approved these changes
Feb 20, 2026
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
Looks great to me! 😃
I requested review from @zsol as the person who originally requested more context in our diagnostics when --output-format=github was specified
amyreese
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates our GitHub output format rendering to include sub-diagnostics and secondary annotations rather than just the concise message. As shown in the test plan, @AlexWaygood and I did some trial and error to figure out how to get these to render correctly, with some help from William on Discord too.
Test Plan
Existing snapshot tests, updated to include a diagnostic with sub-diagnostics (also reflected in some other unmodified output formats), as well as manual testing in ntBre/github-diagnostic-test#2: