[ty] Fix stack overflow for self-referential TypeOf in annotations#23407
Merged
charliermarsh merged 1 commit intomainfrom Feb 19, 2026
Merged
[ty] Fix stack overflow for self-referential TypeOf in annotations#23407charliermarsh merged 1 commit intomainfrom
TypeOf in annotations#23407charliermarsh merged 1 commit intomainfrom
Conversation
Typing conformance resultsNo changes detected ✅ |
Memory usage reportMemory usage unchanged ✅ |
|
ibraheemdev
approved these changes
Feb 19, 2026
2025435 to
f54a477
Compare
knutwannheden
pushed a commit
to openrewrite/ruff
that referenced
this pull request
Feb 20, 2026
…stral-sh#23407) ## Summary When a function references itself via `TypeOf` in a deferred annotation (`def foo(x: "TypeOf[foo]")`), the resulting `FunctionType` contains itself as a parameter type, forming a cycle. Closes astral-sh/ty#2800.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a function references itself via
TypeOfin a deferred annotation (def foo(x: "TypeOf[foo]")), the resultingFunctionTypecontains itself as a parameter type, forming a cycle.Closes astral-sh/ty#2800.