[ty] Visit parameters in source order#23403
Merged
charliermarsh merged 1 commit intomainfrom Feb 19, 2026
Merged
Conversation
charliermarsh
added
bug
charliermarsh
force-pushed
the
charlie/args-source
branch
from
c92ed5e to
181b4e1
Compare
charliermarsh
requested review from
AlexWaygood,
BurntSushi,
Gankra,
MichaReiser,
carljm,
dcreager,
dhruvmanila and
sharkdp
as code owners
|
AlexWaygood
approved these changes
Feb 18, 2026
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
I would flatten the state onto the ParametersSourceOrderIterator struct (see inline comment), but LGTM!
charliermarsh
force-pushed
the
charlie/args-source
branch
from
181b4e1 to
ff4fe79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
Parameters::visit_source_orderusedParametersIteratorwhich visits in type-based order. For well-formed Python code, this matches source order; but error recovery can produce ASTs likedef foo(**kwargs, a):.