[ty] Visit pattern arguments in source order#23398
Merged
charliermarsh merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
charliermarsh
added
bug
charliermarsh
force-pushed
the
charlie/pattern-source
branch
from
60d00f3 to
b7c33c0
Compare
charliermarsh
requested review from
AlexWaygood,
BurntSushi,
Gankra,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
AlexWaygood
approved these changes
Feb 18, 2026
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Nice, I suspected the bug was something like this. LGTM!
Member
|
I bet there are probably other invalid-syntax scenarios where we make this mistake (but finding those doesn't need to block merging this, obviously) |
|
charliermarsh
added a commit
that referenced
this pull request
Feb 18, 2026
## Summary Like #23398, but for `case {**rest, 'key': value}`. The code previously assumed that `**rest` always came last. --------- Co-authored-by: Alex Waygood <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PatternArguments::visit_source_order()visited all positional patterns first, then all keyword patterns. But keyword patterns can appear before positional patterns in the source text:The visitor would process
attrfirst, thenvalue=ast.Name(id).We now visit in source order using the pattern established via
arguments_source_order.Closes astral-sh/ty#2417.