[ty] Validate annotated assignments to attributes on self#23388
Merged
charliermarsh merged 1 commit intomainfrom Feb 19, 2026
Merged
[ty] Validate annotated assignments to attributes on self#23388charliermarsh merged 1 commit intomainfrom
charliermarsh merged 1 commit intomainfrom
Conversation
Typing conformance resultsNo changes detected ✅ |
|
Memory usage reportMemory usage unchanged ✅ |
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-await |
0 | 40 | 0 |
unused-type-ignore-comment |
0 | 40 | 0 |
invalid-assignment |
25 | 0 | 0 |
invalid-argument-type |
0 | 0 | 1 |
invalid-return-type |
0 | 1 | 0 |
| Total | 25 | 81 | 1 |
Contributor
|
Woah folks literally write |
oconnor663
approved these changes
Feb 18, 2026
| let target_ty = if let Some(value_ty) = value_ty { | ||
| let declared_ty = annotated.inner_type(); | ||
| if value_ty.is_assignable_to(self.db(), declared_ty) { | ||
| value_ty |
Contributor
There was a problem hiding this comment.
@carljm were we recently discussing using the annotated type in all cases, instead of the inferred type? Should we do that here?
Contributor
There was a problem hiding this comment.
No, I think we should make that change separately and consistently in all the places, and keep this PR more focused on validating the self.attr assignment.
carljm
approved these changes
Feb 18, 2026
| let target_ty = if let Some(value_ty) = value_ty { | ||
| let declared_ty = annotated.inner_type(); | ||
| if value_ty.is_assignable_to(self.db(), declared_ty) { | ||
| value_ty |
Contributor
There was a problem hiding this comment.
No, I think we should make that change separately and consistently in all the places, and keep this PR more focused on validating the self.attr assignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes astral-sh/ty#2840.