[ty] Consider synthesized methods and ClassVar-qualified declarations when determining whether an abstract method has been overridden in a subclass#23381
Merged
AlexWaygood merged 1 commit intomainfrom Feb 17, 2026
Conversation
…ns when determining whether an abstract method has been overridden in a subclass
Typing conformance resultsNo changes detected ✅ |
Memory usage reportMemory usage unchanged ✅ |
|
carljm
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is another standalone PR pulled out of #22898, to reduce the diff on that PR.
Currently we emit a false-positive
abstract-method-in-final-classdiagnostic on this class, because we do not see that the synthesized__lt__method created by@dataclass(order=True)has overridden the abstract__lt__method from the class's superclass:We also currently do not recognise
ClassVardeclarations in a subclass as overriding an abstract method/property on a base class. While an annotation without a binding is not sufficient at runtime as an abstract method override, theClassVarqualifier serves as an explicit declaration from the user to the type checker that the attribute will be accessible on the class object itself (not simply instances of the class) at runtime. We therefore choose to treatClassVardeclarations as overrides of abstract methods from superclasses.Test Plan
mdtests updated/extended