[ty] Make [abstract-method-in-final-class] diagnostics less verbose for classes with many abstract methods#23379
Merged
AlexWaygood merged 1 commit intomainfrom Feb 17, 2026
Conversation
… for classes with many abstract methods
Typing conformance resultsNo changes detected ✅ |
|
Memory usage reportMemory usage unchanged ✅ |
carljm
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Another PR pulled out of #22898 to reduce the diff on that PR.
If an
@finalclass has many unimplemented abstract methods, we currently emit a diagnostic with an extremely long summary message. For this snippet:We currently emit this diagnostic:
Screenshot
The ecosystem report on early versions of #22898 pointed out that it's not unusual to have a class with lots of abstract methods, so the status quo here seems unreasonable. This PR limits the number of diagnostics we print to the terminal to 3 by default, unless
--verbosehas been specified on the command line. The new default diagnostic is:Screenshot
And if you specify
--verbose, it becomes:Screenshot
Test Plan
Mdtests added.
Testing this feature necessitated adding the ability to specify
verbose = truein a TOML config block in mdtests.