[ty] Extract helper closures for literal-to-Sequence relation checks#23344
Closed
AlexWaygood wants to merge 3 commits intomainfrom
Closed
[ty] Extract helper closures for literal-to-Sequence relation checks#23344AlexWaygood wants to merge 3 commits intomainfrom
AlexWaygood wants to merge 3 commits intomainfrom
Conversation
Typing conformance resultsNo changes detected ✅ |
Memory usage reportMemory usage unchanged ✅ |
|
Reduce code duplication between the `StringLiteral` and `BytesLiteral` branches in `has_relation_to_impl` by extracting shared logic into two closures: - `literal_sequence_precheck`: handles the early returns (target is the literal's own class, or is not in `Sequence`'s MRO) without computing element types, preserving the lazy allocation behavior of the original. - `literal_sequence_relation`: builds the `Sequence[spec]` type from deduplicated element types and checks the relation. https://claude.ai/code/session_0186dunfkX35aawxjdTsWm1v
1b2bc9b to
14c24f1
Compare
Member
Author
|
seems to result in slowdowns of up to 3% on Codspeed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reduce duplicated
has_relation_to_implbranches for bytes-literals and string-literalsTest Plan
existing tests