[ty] Support shellexpand for configuration paths by charliermarsh · Pull Request #23274 · astral-sh/ruff

charliermarsh · 2026-02-14T01:47:50Z

Summary

This matches the approach and behavior we use in Ruff.

Closes astral-sh/ty#2811.

astral-sh-bot · 2026-02-14T01:49:47Z

Typing conformance results

No changes detected ✅

astral-sh-bot · 2026-02-14T01:50:35Z

Memory usage report

Memory usage unchanged ✅

astral-sh-bot · 2026-02-14T01:51:35Z

`mypy_primer` results

Changes were detected when running on open source projects

spack (https://github.com/spack/spack)
- lib/spack/spack/detection/path.py:169:33: error[invalid-argument-type] Argument to function `dedupe_paths` is incorrect: Expected `list[str]`, found `Unknown | list[Unknown | int | str | ... omitted 3 union elements]`
+ lib/spack/spack/detection/path.py:169:33: error[invalid-argument-type] Argument to function `dedupe_paths` is incorrect: Expected `list[str]`, found `Unknown | list[int | str | bytes | ... omitted 3 union elements]`

rich (https://github.com/Textualize/rich)
- tests/test_tools.py:17:17: error[invalid-argument-type] Argument to function `next` is incorrect: Expected `SupportsNext[Unknown]`, found `Iterable[tuple[bool, Unknown | str]]`
+ tests/test_tools.py:17:17: error[invalid-argument-type] Argument to function `next` is incorrect: Expected `SupportsNext[Unknown]`, found `Iterable[tuple[bool, str | Unknown]]`
- tests/test_tools.py:18:17: error[invalid-argument-type] Argument to function `next` is incorrect: Expected `SupportsNext[Unknown]`, found `Iterable[tuple[bool, Unknown | str]]`
+ tests/test_tools.py:18:17: error[invalid-argument-type] Argument to function `next` is incorrect: Expected `SupportsNext[Unknown]`, found `Iterable[tuple[bool, str | Unknown]]`
- tests/test_tools.py:19:17: error[invalid-argument-type] Argument to function `next` is incorrect: Expected `SupportsNext[Unknown]`, found `Iterable[tuple[bool, Unknown | str]]`
+ tests/test_tools.py:19:17: error[invalid-argument-type] Argument to function `next` is incorrect: Expected `SupportsNext[Unknown]`, found `Iterable[tuple[bool, str | Unknown]]`
- tests/test_tools.py:20:17: error[invalid-argument-type] Argument to function `next` is incorrect: Expected `SupportsNext[Unknown]`, found `Iterable[tuple[bool, Unknown | str]]`
+ tests/test_tools.py:20:17: error[invalid-argument-type] Argument to function `next` is incorrect: Expected `SupportsNext[Unknown]`, found `Iterable[tuple[bool, str | Unknown]]`

sockeye (https://github.com/awslabs/sockeye)
- sockeye/output_handler.py:254:80: error[invalid-argument-type] Argument to function `__new__` is incorrect: Expected `Iterable[list[str] | Unknown]`, found `list[list[str]] | None`
+ sockeye/output_handler.py:254:80: error[invalid-argument-type] Argument to function `__new__` is incorrect: Expected `Iterable[Unknown | list[str]]`, found `list[list[str]] | None`

pylint (https://github.com/pycqa/pylint)
- pylint/checkers/refactoring/implicit_booleaness_checker.py:219:24: error[unresolved-attribute] Attribute `as_string` is not defined on `str` in union `Unknown | str`
+ pylint/checkers/refactoring/implicit_booleaness_checker.py:219:24: error[unresolved-attribute] Attribute `as_string` is not defined on `str` in union `str | Unknown`
- pylint/checkers/refactoring/implicit_booleaness_checker.py:219:62: error[unresolved-attribute] Attribute `as_string` is not defined on `str` in union `Unknown | str`
+ pylint/checkers/refactoring/implicit_booleaness_checker.py:219:62: error[unresolved-attribute] Attribute `as_string` is not defined on `str` in union `str | Unknown`
- pylint/checkers/refactoring/implicit_booleaness_checker.py:222:27: error[unresolved-attribute] Attribute `as_string` is not defined on `str` in union `(Unknown & ~None) | str`
+ pylint/checkers/refactoring/implicit_booleaness_checker.py:222:27: error[unresolved-attribute] Attribute `as_string` is not defined on `str` in union `str | (Unknown & ~None)`
- pylint/checkers/refactoring/implicit_booleaness_checker.py:236:29: error[unresolved-attribute] Attribute `as_string` is not defined on `str` in union `Unknown | str`
+ pylint/checkers/refactoring/implicit_booleaness_checker.py:236:29: error[unresolved-attribute] Attribute `as_string` is not defined on `str` in union `str | Unknown`
- pylint/checkers/refactoring/implicit_booleaness_checker.py:239:29: error[unresolved-attribute] Attribute `as_string` is not defined on `str` in union `Unknown | str`
+ pylint/checkers/refactoring/implicit_booleaness_checker.py:239:29: error[unresolved-attribute] Attribute `as_string` is not defined on `str` in union `str | Unknown`

artigraph (https://github.com/artigraph/artigraph)
- tests/arti/types/test_types.py:100:51: error[invalid-argument-type] Argument is incorrect: Expected `frozenset[Any]`, found `frozenset[float | Unknown | int] | list[Unknown | int | float] | tuple[float | Unknown | int, ...]`
+ tests/arti/types/test_types.py:100:51: error[invalid-argument-type] Argument is incorrect: Expected `frozenset[Any]`, found `frozenset[float | Unknown | int] | list[int | Unknown | float] | tuple[float | Unknown | int, ...]`

Expression (https://github.com/cognitedata/Expression)
+ tests/test_compose.py:21:16: error[invalid-assignment] Object of type `(Never, /) -> Never` is not assignable to `(int, /) -> int`
- Found 204 diagnostics
+ Found 205 diagnostics

meson (https://github.com/mesonbuild/meson)
- mesonbuild/dependencies/cuda.py:137:76: error[invalid-argument-type] Argument to function `version_compare_many` is incorrect: Expected `str`, found `Unknown | str | None`
+ mesonbuild/dependencies/cuda.py:137:76: error[invalid-argument-type] Argument to function `version_compare_many` is incorrect: Expected `str`, found `str | None | Unknown`

openlibrary (https://github.com/internetarchive/openlibrary)
- openlibrary/catalog/utils/__init__.py:132:17: error[unresolved-attribute] Attribute `search` is not defined on `str` in union `Unknown | str`
+ openlibrary/catalog/utils/__init__.py:132:17: error[unresolved-attribute] Attribute `search` is not defined on `str` in union `str | Unknown`

dd-trace-py (https://github.com/DataDog/dd-trace-py)
- scripts/freshvenvs.py:343:69: error[invalid-argument-type] Argument to function `_versions_fully_cover_bounds` is incorrect: Expected `list[str]`, found `list[Unknown | Version] & ~AlwaysFalsy`
+ scripts/freshvenvs.py:343:69: error[invalid-argument-type] Argument to function `_versions_fully_cover_bounds` is incorrect: Expected `list[str]`, found `list[Version | Unknown] & ~AlwaysFalsy`
- tests/tracer/test_span.py:193:29: error[invalid-argument-type] Argument to bound method `set_metric` is incorrect: Expected `int | float`, found `Span | Unknown | None | ... omitted 6 union elements`
+ tests/tracer/test_span.py:193:29: error[invalid-argument-type] Argument to bound method `set_metric` is incorrect: Expected `int | float`, found `int | float | complex | ... omitted 6 union elements`

ibis (https://github.com/ibis-project/ibis)
- ibis/selectors.py:333:16: error[invalid-return-type] Return type does not match returned value: expected `frozenset[str]`, found `frozenset[Unknown | str | Buffer]`
+ ibis/selectors.py:333:16: error[invalid-return-type] Return type does not match returned value: expected `frozenset[str]`, found `frozenset[str | Buffer | Unknown]`
- ibis/selectors.py:428:13: error[invalid-assignment] Object of type `frozenset[Unknown | str]` is not assignable to `tuple[str | Column, ...]`
+ ibis/selectors.py:428:13: error[invalid-assignment] Object of type `frozenset[str | Unknown]` is not assignable to `tuple[str | Column, ...]`

bokeh (https://github.com/bokeh/bokeh)
- src/bokeh/layouts.py:670:16: error[invalid-return-type] Return type does not match returned value: expected `list[L@_parse_children_arg]`, found `list[L@_parse_children_arg | list[L@_parse_children_arg]]`
+ src/bokeh/layouts.py:670:21: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `Iterable[L@_parse_children_arg]`, found `tuple[L@_parse_children_arg | list[L@_parse_children_arg], ...]`

pandas (https://github.com/pandas-dev/pandas)
- pandas/core/methods/describe.py:215:21: error[not-iterable] Object of type `Sized | Unknown` may not be iterable
+ pandas/core/methods/describe.py:215:21: error[not-iterable] Object of type `Unknown | Sized` may not be iterable

materialize (https://github.com/MaterializeInc/materialize)
+ misc/python/materialize/cli/mz_workload_anonymize.py:251:13: error[no-matching-overload] No overload of bound method `join` matches arguments
- Found 536 diagnostics
+ Found 537 diagnostics

jax (https://github.com/google/jax)
- jax/_src/pallas/hlo_interpreter.py:433:37: error[invalid-argument-type] Argument is incorrect: Expected `int`, found `int | DynamicGridDim | Unknown`
+ jax/_src/pallas/hlo_interpreter.py:433:37: error[invalid-argument-type] Argument is incorrect: Expected `int`, found `DynamicGridDim | Unknown | int`
- jax/_src/pallas/mosaic/interpret/interpret_pallas_call.py:1895:37: error[invalid-argument-type] Argument is incorrect: Expected `int`, found `int | DynamicGridDim | Unknown`
+ jax/_src/pallas/mosaic/interpret/interpret_pallas_call.py:1895:37: error[invalid-argument-type] Argument is incorrect: Expected `int`, found `DynamicGridDim | Unknown | int`
- jax/_src/pallas/pallas_call.py:852:37: error[invalid-argument-type] Argument is incorrect: Expected `int`, found `int | DynamicGridDim | Unknown`
+ jax/_src/pallas/pallas_call.py:852:37: error[invalid-argument-type] Argument is incorrect: Expected `int`, found `DynamicGridDim | Unknown | int`
- jax/collect_profile.py:110:17: error[unresolved-attribute] Attribute `glob` is not defined on `PathLike[str]`, `int`, `str`, `bytes`, `PathLike[bytes]` in union `Unknown | PathLike[str] | int | ... omitted 3 union elements`
+ jax/collect_profile.py:110:17: error[unresolved-attribute] Attribute `glob` is not defined on `PathLike[str]`, `int`, `str`, `bytes`, `PathLike[bytes]` in union `PathLike[str] | Unknown | int | ... omitted 3 union elements`
- jax/collect_profile.py:113:22: error[unsupported-operator] Operator `/` is not supported between objects of type `Unknown | PathLike[str] | int | ... omitted 3 union elements` and `Literal["remote.trace.json.gz"]`
+ jax/collect_profile.py:113:22: error[unsupported-operator] Operator `/` is not supported between objects of type `PathLike[str] | Unknown | int | ... omitted 3 union elements` and `Literal["remote.trace.json.gz"]`

core (https://github.com/home-assistant/core)
- homeassistant/components/teslemetry/climate.py:154:37: error[unresolved-attribute] Attribute `index` is not defined on `None` in union `Unknown | list[Unknown | str] | list[str] | None`
+ homeassistant/components/teslemetry/climate.py:154:37: error[unresolved-attribute] Attribute `index` is not defined on `None` in union `Unknown | list[str | Unknown] | list[str] | None`

colour (https://github.com/colour-science/colour)
+ colour/utilities/verbose.py:1071:69: error[invalid-argument-type] Argument to function `getattr` is incorrect: Expected `str`, found `bool | (Unknown & ~None) | <class 'str'>`
- colour/utilities/verbose.py:1071:69: error[invalid-argument-type] Argument to function `getattr` is incorrect: Expected `str`, found `(Unknown & ~None) | <class 'str'> | bool`

astral-sh-bot · 2026-02-14T02:06:18Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

carljm · 2026-02-14T19:07:11Z

Sorry for dumping Claude review on you, but I read this review fully and I think it is correct; doesn't seem like a good use of time for me to re-word it :)

`shellexpand::full()` bypasses the `System` abstraction

The core concern with this PR is that shellexpand::full() calls std::env::var() and dirs::home_dir() directly, completely bypassing the System::env_var() abstraction that ty uses to ensure test isolation and correctness in non-standard runtimes (WASM, LSP).

The RelativePathBuf::absolute() method already receives a &dyn System — but the new shell expansion ignores it:

let expanded = shellexpand::full(self.0.as_str());
let path = expanded.as_deref().unwrap_or(self.0.as_str());

This matters because:

Test isolation is broken: TestSystem overrides like set_env_var("HOME", "/test/home") won't be respected — shellexpand::full() reads the real process environment via std::env::var().
WASM correctness is accidental: In WASM, System::env_var() always returns NotPresent by design. shellexpand::full() bypasses this and calls std::env::var() directly; it likely fails and the unwrap_or fallback kicks in, but this is accidental correctness rather than intentional behavior.
Inconsistency within ty_project: Right nearby in options.rs, PYTHONPATH is correctly read via system.env_var(EnvVars::PYTHONPATH) (line 350). This new code introduces an inconsistency in the same subsystem.

Suggested fix

shellexpand provides full_with_context() which accepts custom closures for env var lookup and home directory resolution. This should be used to route lookups through the System trait:

let expanded = shellexpand::full_with_context(
    self.0.as_str(),
    || system.env_var("HOME").ok(),
    |var| system.env_var(var).map(Some).or_else(|e| match e {
        std::env::VarError::NotPresent => Ok(None),
        other => Err(other),
    }),
);

Other notes

Silent error swallowing: The unwrap_or fallback silently drops expansion errors. If a user writes $NONEXISTENT_VAR/foo, they'll get the literal string as a path with no warning. By contrast, Ruff's configuration.rs propagates the error with .map_err(|e| anyhow!("Invalid ... value: {e}"))?, and ty_server/options.rs at least shows an error message to the user. This is the least informative of all three approaches.
No tests: There don't appear to be any tests for the new behavior — no test that ~ is expanded, no test that $VAR is expanded, no test for the error fallback path.
Existing precedent in ty_server: ty_server/src/session/options.rs:207 already uses shellexpand::full() directly too, so this isn't a new pattern — but extending it further without addressing the underlying issue seems like the wrong direction. This could be a good opportunity to fix both call sites.

carljm

(requesting changes)

charliermarsh · 2026-02-18T03:49:58Z

Wow I thought this one was a layup!

carljm · 2026-02-18T03:50:29Z

that's why I'm here

BurntSushi

Nice! This LGTM now :)

charliermarsh added configuration Related to settings and configuration ty Multi-file analysis & type inference labels Feb 14, 2026

charliermarsh marked this pull request as ready for review February 14, 2026 18:09

charliermarsh requested review from Gankra, MichaReiser, carljm, dcreager and sharkdp as code owners February 14, 2026 18:09

carljm requested changes Feb 14, 2026

View reviewed changes

carljm self-assigned this Feb 15, 2026

charliermarsh marked this pull request as draft February 18, 2026 03:52

[ty] Support shellexpand for configuration paths

b7c17da

charliermarsh force-pushed the charlie/shell branch from 411344f to cb06350 Compare February 18, 2026 04:01

Address review

8ab95fd

charliermarsh force-pushed the charlie/shell branch from cb06350 to 8ab95fd Compare February 18, 2026 04:05

charliermarsh marked this pull request as ready for review February 18, 2026 04:05

charliermarsh requested a review from BurntSushi as a code owner February 18, 2026 04:05

BurntSushi approved these changes Feb 18, 2026

View reviewed changes

charliermarsh merged commit 0611e7b into main Feb 18, 2026
50 checks passed

charliermarsh deleted the charlie/shell branch February 18, 2026 16:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ty] Support shellexpand for configuration paths#23274

[ty] Support shellexpand for configuration paths#23274
charliermarsh merged 2 commits intomainfrom
charlie/shell

charliermarsh commented Feb 14, 2026

Uh oh!

astral-sh-bot bot commented Feb 14, 2026 •

edited

Loading

Uh oh!

astral-sh-bot bot commented Feb 14, 2026 •

edited

Loading

Uh oh!

astral-sh-bot bot commented Feb 14, 2026 •

edited

Loading

Uh oh!

astral-sh-bot bot commented Feb 14, 2026 •

edited

Loading

Uh oh!

carljm commented Feb 14, 2026

Uh oh!

carljm left a comment

Uh oh!

charliermarsh commented Feb 18, 2026

Uh oh!

carljm commented Feb 18, 2026

Uh oh!

BurntSushi left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

charliermarsh commented Feb 14, 2026

Summary

Uh oh!

astral-sh-bot bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Typing conformance results

Uh oh!

astral-sh-bot bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Memory usage report

Uh oh!

astral-sh-bot bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mypy_primer results

Uh oh!

astral-sh-bot bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Formatter (stable)

Formatter (preview)

Uh oh!

carljm commented Feb 14, 2026

shellexpand::full() bypasses the System abstraction

Suggested fix

Other notes

Uh oh!

carljm left a comment

Choose a reason for hiding this comment

Uh oh!

charliermarsh commented Feb 18, 2026

Uh oh!

carljm commented Feb 18, 2026

Uh oh!

BurntSushi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

astral-sh-bot bot commented Feb 14, 2026 •

edited

Loading

astral-sh-bot bot commented Feb 14, 2026 •

edited

Loading

astral-sh-bot bot commented Feb 14, 2026 •

edited

Loading

`mypy_primer` results

astral-sh-bot bot commented Feb 14, 2026 •

edited

Loading

`ruff-ecosystem` results

`shellexpand::full()` bypasses the `System` abstraction