Use DisplayDiagnosticsConfig::program for Ruff's GitHub output#23240
Merged
Use DisplayDiagnosticsConfig::program for Ruff's GitHub output#23240
DisplayDiagnosticsConfig::program for Ruff's GitHub output#23240Conversation
Summary -- This is a follow-up to #22125, which added a `program` field to the shared `DisplayDiagnosticConfig` type. We can reuse this in the GitHub rendering too to avoid some of the special casing we had just for Ruff. The one wrinkle here is that we previously used capital `Ruff` for GitHub diagnostics, but we use `ruff` in the JUnit diagnostics. I think it's probably fine to change this in the GitHub diagnostics, but it felt worth calling out. Test Plan -- Existing tests with updated snapshots showing the case change
Contributor
Author
|
(This is mostly
internal
|
|
ntBre
requested review from
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
carljm
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up to #22125, which added a
programfield to the sharedDisplayDiagnosticConfigtype. We can reuse this in the GitHub rendering too toavoid some of the special casing we had just for Ruff.
The one wrinkle here is that we previously used capital
Rufffor GitHubdiagnostics, but we use
ruffin the JUnit diagnostics. I think it's probablyfine to change this in the GitHub diagnostics, but it felt worth calling out.
Test Plan
Existing tests with updated snapshots showing the case change