[ty] include overload declarations in find references#23215
Merged
sharkdp merged 2 commits intoastral-sh:mainfrom Feb 11, 2026
Merged
[ty] include overload declarations in find references#23215sharkdp merged 2 commits intoastral-sh:mainfrom
sharkdp merged 2 commits intoastral-sh:mainfrom
Conversation
Typing conformance resultsNo changes detected ✅ |
|
Memory usage reportMemory usage unchanged ✅ |
sharkdp
approved these changes
Feb 11, 2026
Contributor
sharkdp
left a comment
There was a problem hiding this comment.
Thank you very much. I made a small change myself to avoid having to copy the vector. And I'm adding the original definition along with all co-definitions, so we don't have to filter out the original definition now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes astral-sh/ty/issues/886
Previously, find references/rename did not include the full overload set. We now correctly provide all overload declarations and the implementation.
Test Plan
find_referencestest for overloaded function declarations