[ty] Fix wrong inlay hints for overloaded function arguments#23179
Merged
charliermarsh merged 2 commits intomainfrom Feb 9, 2026
Merged
[ty] Fix wrong inlay hints for overloaded function arguments#23179charliermarsh merged 2 commits intomainfrom
charliermarsh merged 2 commits intomainfrom
Conversation
charliermarsh
added
server
Typing conformance resultsNo changes detected ✅ |
|
charliermarsh
force-pushed
the
charlie/overload-lsp
branch
from
7cb8285 to
82a31c8
Compare
charliermarsh
requested review from
AlexWaygood,
BurntSushi,
Gankra,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
AlexWaygood
approved these changes
Feb 9, 2026
| /// | ||
| /// Falls back to arity-based matching if type-based resolution fails. | ||
| fn resolve_call_signature<'db>( | ||
| db: &'db dyn Db, |
Member
There was a problem hiding this comment.
Rather than passing in db as a separate argument, I think you can just add let db = model.db(); as the first line of the function
Comment on lines
811
to
813
| let callable_type = func_type | ||
| .try_upcast_to_callable(model.db()) | ||
| .map(|callables| callables.into_type(model.db()))?; |
Member
There was a problem hiding this comment.
Suggested change
| let callable_type = func_type | |
| .try_upcast_to_callable(model.db()) | |
| .map(|callables| callables.into_type(model.db()))?; | |
| let callable_type = func_type.try_upcast_to_callable(db)?.into_type(db); |
| .bindings(model.db()) | ||
| .match_parameters(model.db(), &call_arguments); | ||
|
|
||
| let db = model.db(); |
Member
There was a problem hiding this comment.
if you moved this assignment higher up in the function, you could replace four more model.db() calls with db
Comment on lines
825
to
828
| let bindings = match &checked { | ||
| Ok(bindings) => bindings, | ||
| Err(err) => &err.1, | ||
| }; |
Member
There was a problem hiding this comment.
nit: I'd use .unwrap_or_else() here
| .try_upcast_to_callable(model.db()) | ||
| .map(|callables| callables.into_type(model.db()))?; | ||
|
|
||
| let args = CallArguments::from_arguments_typed(&call_expr.arguments, |_, splatted_value| { |
Member
There was a problem hiding this comment.
This is a pre-existing issue, but: I'm a bit confused about why the passed-in closure here needs to take 2 arguments. It looks like there are now two callsites of CallArguments::from_arguments_typed() on this PR branch, and both callsites pass in a closure that ignores the first argument passed into it
Comment on lines
821
to
828
| let bindings = callable_type.bindings(db).match_parameters(db, &args); | ||
|
|
||
| // Extract the `Bindings` regardless of whether type checking succeeded or failed. | ||
| let checked = bindings.check_types(db, &args, TypeContext::default(), &[]); | ||
| let bindings = match &checked { | ||
| Ok(bindings) => bindings, | ||
| Err(err) => &err.1, | ||
| }; |
Member
There was a problem hiding this comment.
nit
Suggested change
| let bindings = callable_type.bindings(db).match_parameters(db, &args); | |
| // Extract the `Bindings` regardless of whether type checking succeeded or failed. | |
| let checked = bindings.check_types(db, &args, TypeContext::default(), &[]); | |
| let bindings = match &checked { | |
| Ok(bindings) => bindings, | |
| Err(err) => &err.1, | |
| }; | |
| let bindings = callable_type | |
| .bindings(db) | |
| .match_parameters(db, &args) | |
| .check_types(db, &args, TypeContext::default(), &[]) | |
| .unwrap_or_else(|CallError(_, bindings)| *bindings); |
charliermarsh
force-pushed
the
charlie/overload-lsp
branch
from
82a31c8 to
7f4f996
Compare
carljm
added a commit
to Hugo-Polloli/ruff
that referenced
this pull request
Feb 9, 2026
* main: (45 commits) [ty] Fix wrong inlay hints for overloaded function arguments (astral-sh#23179) [ty] Respect `@no_type_check` when combined with other decorators (astral-sh#23177) [ty] Use type context when inferring constructor argument types (astral-sh#23139) [`airflow`] Add ruff rules to catch deprecated attribute access from context key for Airflow 3.0 (`AIR301`) (astral-sh#22850) Support formatting `pycon` markdown code blocks (astral-sh#23112) Markdown formatting in LSP (astral-sh#23063) Instruct Claude to use comments more sparingly (astral-sh#23181) [`flake8-gettext`] Fix false negatives for plural argument of ngettext (`INT001`, `INT002`, `INT003`) (astral-sh#21078) [ty] Invoking goto-def on parentheses of a class constructor call takes you too constructor method [ty] Make goto definition on class constructor always go to class definition [ty] Assign lower completions ranking to deprecated functions and classes (astral-sh#23089) [ty] Fix parameter references across files via keyword args (astral-sh#23012) [ty] Exclude enclosing class for base completions (astral-sh#23141) [`pyupgrade`] Fix syntax error on string with newline escape and comment (`UP037`) (astral-sh#22968) [ty] Improve documentation for `expect_single_definition` method (astral-sh#23175) [ty] Configure check mode for all projects Add `home-assistant` to ecosystem projects (astral-sh#23132) Add tabbed shell completion documentation (astral-sh#23169) Bump typing conformance-suite pin (astral-sh#23174) [ty] Fix invalid diagnostic location for a sub-call to a specialized ParamSpec (astral-sh#23036) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inlay hints for function call arguments were showing parameter names from the wrong overload variant because they only performed arity-based matching.
Closes astral-sh/ty#1985.