Merged
Conversation
Summary -- I think Micha suggested this before, but I couldn't find the message. This also may have helped to catch #23125. Test Plan -- CI on this PR. I think this is a pretty large repo, so I want to make sure it doesn't cause too much of a slowdown, in addition to the job passing. However, it only takes ~4 seconds to check locally compared to ~22 for airflow, despite containing more files (16k vs 6.5k) and more lines of code (3 million vs 1.2 million).
|
Contributor
Author
|
I guess I'm not really sure how I planned to check the timings since I don't know how reproducible they are, but these look okay to me:
If these are accurate, in the worst case, it adds 16 seconds. |
dylwil3
approved these changes
Feb 7, 2026
carljm
added a commit
to Hugo-Polloli/ruff
that referenced
this pull request
Feb 9, 2026
* main: (45 commits) [ty] Fix wrong inlay hints for overloaded function arguments (astral-sh#23179) [ty] Respect `@no_type_check` when combined with other decorators (astral-sh#23177) [ty] Use type context when inferring constructor argument types (astral-sh#23139) [`airflow`] Add ruff rules to catch deprecated attribute access from context key for Airflow 3.0 (`AIR301`) (astral-sh#22850) Support formatting `pycon` markdown code blocks (astral-sh#23112) Markdown formatting in LSP (astral-sh#23063) Instruct Claude to use comments more sparingly (astral-sh#23181) [`flake8-gettext`] Fix false negatives for plural argument of ngettext (`INT001`, `INT002`, `INT003`) (astral-sh#21078) [ty] Invoking goto-def on parentheses of a class constructor call takes you too constructor method [ty] Make goto definition on class constructor always go to class definition [ty] Assign lower completions ranking to deprecated functions and classes (astral-sh#23089) [ty] Fix parameter references across files via keyword args (astral-sh#23012) [ty] Exclude enclosing class for base completions (astral-sh#23141) [`pyupgrade`] Fix syntax error on string with newline escape and comment (`UP037`) (astral-sh#22968) [ty] Improve documentation for `expect_single_definition` method (astral-sh#23175) [ty] Configure check mode for all projects Add `home-assistant` to ecosystem projects (astral-sh#23132) Add tabbed shell completion documentation (astral-sh#23169) Bump typing conformance-suite pin (astral-sh#23174) [ty] Fix invalid diagnostic location for a sub-call to a specialized ParamSpec (astral-sh#23036) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I think Micha suggested this before, but I couldn't find the message. This also
may have helped to catch #23125.
Test Plan
CI on this PR. I think this is a pretty large repo, so I want to make sure it
doesn't cause too much of a slowdown, in addition to the job passing. However,
it only takes ~4 seconds to check locally compared to ~22 for airflow, despite
containing more files (16k vs 6.5k) and more lines of code (3 million vs 1.2
million).