Conversation
Typing conformance resultsNo changes detected ✅ |
|
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
unsupported-operator |
79 | 0 | 0 |
invalid-return-type |
4 | 0 | 0 |
possibly-missing-attribute |
4 | 0 | 0 |
invalid-argument-type |
3 | 0 | 0 |
invalid-assignment |
0 | 1 | 0 |
unresolved-attribute |
1 | 0 | 0 |
| Total | 91 | 1 | 0 |
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
sharkdp
reviewed
Feb 6, 2026
Comment on lines
+1319
to
+1322
| // Use the narrowed type for subsequent comparisons in a chain. | ||
| last_rhs_ty = Some(IntersectionType::from_elements(self.db, [rhs_ty, ty])); | ||
| } else { | ||
| last_rhs_ty = Some(rhs_ty); |
Contributor
There was a problem hiding this comment.
There is a branch above that handles narrowing for if type(x) is Y etc, and it has a continue. Are we still updating last_rhs_ty in that branch?
sharkdp
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See: #23084 (comment)