[ty] error for attribute access on union where some elements lack the attribute#23042
Merged
oconnor663 merged 1 commit intomainfrom Feb 12, 2026
Merged
[ty] error for attribute access on union where some elements lack the attribute#23042oconnor663 merged 1 commit intomainfrom
oconnor663 merged 1 commit intomainfrom
Conversation
oconnor663
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
Typing conformance results improved 🎉The percentage of diagnostics emitted that were expected errors increased from 83.49% to 83.51%. The percentage of expected errors that received a diagnostic increased from 74.24% to 74.33%. Summary
True positives addedDetails
|
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
unresolved-attribute |
9,715 | 0 | 0 |
possibly-missing-attribute |
0 | 9,653 | 0 |
unsupported-operator |
84 | 1 | 50 |
not-subscriptable |
96 | 1 | 0 |
unused-type-ignore-comment |
0 | 25 | 0 |
invalid-argument-type |
4 | 7 | 9 |
no-matching-overload |
0 | 20 | 0 |
invalid-parameter-default |
0 | 0 | 7 |
invalid-return-type |
0 | 1 | 3 |
invalid-assignment |
0 | 0 | 2 |
not-iterable |
0 | 0 | 2 |
| Total | 9,899 | 9,708 | 73 |
|
Contributor
|
Hmm -- my assumption of how we'd fix this issue had been that we would map over the union earlier in attribute access, therefore avoiding the |
carljm
approved these changes
Feb 3, 2026
Contributor
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
This clearly has a positive conformance and ecosystem impact, so I think we should go ahead with it for now. I still wonder if we may run into cases in the future that motivate us to map over unions earlier in attribute access, but landing this doesn't prevent us from doing that in future, when it's well-motivated.
Contributor
|
Currently this PR has the |
oconnor663
force-pushed
the
jack/union_attribute_access
branch
from
07fe7bf to
c32c923
Compare
oconnor663
force-pushed
the
jack/union_attribute_access
branch
from
c32c923 to
5b344d6
Compare
Contributor
Author
|
I can't figure out another way to do this that doesn't involve more duplication than what's here, so I'm going to land this as-is. |
Memory usage reportMemory usage unchanged ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes astral-sh/ty#1656