[ty] Fix invalid diagnostic location for a sub-call to a specialized ParamSpec#23036
Merged
dhruvmanila merged 15 commits intoastral-sh:mainfrom Feb 9, 2026
Merged
[ty] Fix invalid diagnostic location for a sub-call to a specialized ParamSpec#23036dhruvmanila merged 15 commits intoastral-sh:mainfrom
dhruvmanila merged 15 commits intoastral-sh:mainfrom
Conversation
11happy
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
Signed-off-by: Bhuminjay <[email protected]>
Signed-off-by: Bhuminjay <[email protected]>
11happy
force-pushed
the
fix_diagnostic_location
branch
from
60fc1a5 to
5c27788
Compare
Typing conformance resultsNo changes detected ✅ |
Signed-off-by: Bhuminjay <[email protected]>
Signed-off-by: Bhuminjay <[email protected]>
dhruvmanila
requested changes
Feb 3, 2026
Member
dhruvmanila
left a comment
dhruvmanila
left a comment
There was a problem hiding this comment.
Thank you! I've some changes that I've recommended but otherwise this looks good.
crates/ty_python_semantic/resources/mdtest/param_spec_errors.md
Outdated
Show resolved
Hide resolved
crates/ty_python_semantic/resources/mdtest/param_spec_errors.md
Outdated
Show resolved
Hide resolved
Member
|
(I've removed the "fixes" directive as there are other parts that are still remaining after this PR.) |
Signed-off-by: Bhuminjay <[email protected]>
…c_errors.md_-_test_for_paramspec_e…_(4b332d9e024d6e7b).snap
Contributor
Author
|
|
Contributor
|
Mypy-primer is failing because of this panic: https://github.com/astral-sh/ruff/actions/runs/21655910487/job/62430518631?pr=23036#step:6:1100 Seems likely to have been introduced by the changes in this PR. If you are not sure what the cause is, you can clone jax and run ty on it and try to reproduce locally. |
Signed-off-by: Bhuminjay <[email protected]>
…tion' into fix_diagnostic_location
Signed-off-by: Bhuminjay <[email protected]>
Signed-off-by: Bhuminjay <[email protected]>
|
Contributor
Author
Thank you very much for pointing it , I was able to debug it, the issue was at call due to offset out of bounds error, even with my initial approach of max index check it was failing the core , at the call sites the synthetic args are not counted so I subtracted it accordingly & it passes now. Thank you : ) |
dhruvmanila
reviewed
Feb 9, 2026
dhruvmanila
approved these changes
Feb 9, 2026
Signed-off-by: Bhuminjay <[email protected]>
carljm
added a commit
to Hugo-Polloli/ruff
that referenced
this pull request
Feb 9, 2026
* main: (45 commits) [ty] Fix wrong inlay hints for overloaded function arguments (astral-sh#23179) [ty] Respect `@no_type_check` when combined with other decorators (astral-sh#23177) [ty] Use type context when inferring constructor argument types (astral-sh#23139) [`airflow`] Add ruff rules to catch deprecated attribute access from context key for Airflow 3.0 (`AIR301`) (astral-sh#22850) Support formatting `pycon` markdown code blocks (astral-sh#23112) Markdown formatting in LSP (astral-sh#23063) Instruct Claude to use comments more sparingly (astral-sh#23181) [`flake8-gettext`] Fix false negatives for plural argument of ngettext (`INT001`, `INT002`, `INT003`) (astral-sh#21078) [ty] Invoking goto-def on parentheses of a class constructor call takes you too constructor method [ty] Make goto definition on class constructor always go to class definition [ty] Assign lower completions ranking to deprecated functions and classes (astral-sh#23089) [ty] Fix parameter references across files via keyword args (astral-sh#23012) [ty] Exclude enclosing class for base completions (astral-sh#23141) [`pyupgrade`] Fix syntax error on string with newline escape and comment (`UP037`) (astral-sh#22968) [ty] Improve documentation for `expect_single_definition` method (astral-sh#23175) [ty] Configure check mode for all projects Add `home-assistant` to ecosystem projects (astral-sh#23132) Add tabbed shell completion documentation (astral-sh#23169) Bump typing conformance-suite pin (astral-sh#23174) [ty] Fix invalid diagnostic location for a sub-call to a specialized ParamSpec (astral-sh#23036) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes part of astral-sh/ty#2198
Test Plan
Added mdtest & snapshots:
Sample Example
for code:
before
After: