[ty] Fix hover showing Unknown for bare Final instance attributes#23003
Merged
[ty] Fix hover showing Unknown for bare Final instance attributes#23003
Unknown for bare Final instance attributes#23003Conversation
charliermarsh
added
server
Typing conformance resultsNo changes detected ✅ |
|
Member
Author
|
I assume the behavior here is intentionally different from how name assignments are handled? This PR makes them more consistent, but I'm likely overlooking the reason that they diverge today. |
charliermarsh
requested review from
AlexWaygood,
Gankra,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
sharkdp
approved these changes
Feb 2, 2026
Contributor
sharkdp
left a comment
sharkdp
left a comment
There was a problem hiding this comment.
Thank you, this seems very reasonable to me.
I assume the behavior here is intentionally different from how name assignments are handled? This PR makes them more consistent, but I'm likely overlooking the reason that they diverge today.
I do not recall any intentional divergence of behavior. A reveal_type(self.a) immediately following the self.a: <type> = <rhs-expr> annotated attribute assignment would also show the RHS type (due to attribute assignment narrowing). So I think this makes sense.
Note that this will not just affect bare Final annotations, but also something like self.a: int = 1 where we previously revealed int instead of Literal[1].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For non-name annotated assignment targets like
self.x: Final = value, the expression type stored forself.xwas the annotation's inner type (Unknown, forFinal).The name-target path (
x: Final = value) already stores the inferred RHS type instead, so we now do the same for attributes.Closes astral-sh/ty#2509.