[ty] add inconsistent-mro autofix that moves Generic[] to the end of the bases list#22998
Conversation
Signed-off-by: Bhuminjay <[email protected]>
Typing conformance resultsNo changes detected ✅ |
|
|
Hii @AlexWaygood would appreciate a review. |
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks, looks good! Some suggestions:
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Signed-off-by: Bhuminjay <[email protected]>
…_Calls_to_`type()`_-_MRO_errors_with_fix_(e8566dec5b35dcae).snap
|
Thanks Alex for such detailed suggestions, I appreciate the explanations, it helps me understand the rust better focused around performance. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
prefect
sphinx
trio
|
|
I have added tests as well, however since comments are there in mdtest file in classes,while pushing a pre-commit job was failing formatting the code section in test file removing the comments hence I have used |
inconsistent-mro autofix that moves Generic[] to the end of the bases list
Nice! I fixed this up for you -- the solution is to add |
Summary
This PR fixes astral-sh/ty#2309
Test Plan
added mdtest & snapshot