Stabilize --output-format in --watch mode#22908
Merged
ntBre merged 1 commit intobrent/0.15.0from Jan 29, 2026
Merged
Conversation
ntBre
changed the title
--output-format in watch mode--output-format in --watch mode
|
amyreese
approved these changes
Jan 28, 2026
Member
amyreese
left a comment
amyreese
left a comment
There was a problem hiding this comment.
Also includes the docker/readme changes.
Summary -- This PR stabilizes the changes from #21097 and closes #19552. Note that this has two effects: - the default output format in `watch` mode becomes `full` instead of `concise` - the `--output-format` flag will now be respected So the default output is now more verbose, but the old stable behavior can be retained by passing `--output-format=concise` (or any other supported format) instead. Test Plan -- Manual testing. I think we tried to set up automated tests in an earlier PR but decided they were too complex.
ntBre
force-pushed
the
brent/stabilize-watch-output-format
branch
from
5926ba4 to
f3cd3a3
Compare
dylwil3
approved these changes
Jan 29, 2026
ntBre
added a commit
that referenced
this pull request
Jan 29, 2026
Summary -- I forgot to include this in #22908, but I think it's okay just to land this on `main` instead of the release branch because the warning isn't actually visible to users anyway, as reported in #19552. We're stabilizing `--output-format` actually being used with `--watch`, so we can just delete this warning. Fixes #19552
ntBre
added a commit
that referenced
this pull request
Jan 29, 2026
Summary -- I forgot to include this in #22908, but I think it's okay just to land this on `main` instead of the release branch because the warning isn't actually visible to users anyway, as reported in #19552. We're stabilizing `--output-format` actually being used with `--watch`, so we can just delete this warning. Fixes #19552
ntBre
added a commit
that referenced
this pull request
Feb 3, 2026
Summary -- This PR stabilizes the changes from #21097 and closes #19552. Note that this has two effects: - the default output format in `--watch` mode becomes `full` instead of `concise` - the `--output-format` flag will now be respected So the default output is now more verbose, but the old stable behavior can be retained by passing `--output-format=concise` (or any other supported format) instead. Test Plan -- Manual testing. I think we tried to set up automated tests in an earlier PR but decided they were too complex. I really should have cropped these, but I'll just collapse them instead: <details><summary>Screenshots</summary> <p> ### Current output, no `--output-format` <img width="783" height="514" alt="image" src="https://github.com/user-attachments/assets/a758daa8-534e-4dab-9cff-858321cede61" /> ### Current output, `--output-format=json` The same as above, the flag has no effect <img width="783" height="514" alt="image" src="https://github.com/user-attachments/assets/e5b0743a-6bd5-4dec-83e0-de24e44567ca" /> ### PR branch output, no `--output-format` Default format is now `full` rather than `concise` <img width="783" height="514" alt="image" src="https://github.com/user-attachments/assets/cf51947d-52e3-4420-83e7-73530557c324" /> ### PR branch output, `--output-format=json` JSON output, the flag works <img width="783" height="514" alt="image" src="https://github.com/user-attachments/assets/e7127c5a-88ad-4b2a-80b4-193b63b631ee" /> </p> </details>
ntBre
added a commit
that referenced
this pull request
Feb 3, 2026
Summary -- This PR stabilizes the changes from #21097 and closes #19552. Note that this has two effects: - the default output format in `--watch` mode becomes `full` instead of `concise` - the `--output-format` flag will now be respected So the default output is now more verbose, but the old stable behavior can be retained by passing `--output-format=concise` (or any other supported format) instead. Test Plan -- Manual testing. I think we tried to set up automated tests in an earlier PR but decided they were too complex. I really should have cropped these, but I'll just collapse them instead: <details><summary>Screenshots</summary> <p> ### Current output, no `--output-format` <img width="783" height="514" alt="image" src="https://github.com/user-attachments/assets/a758daa8-534e-4dab-9cff-858321cede61" /> ### Current output, `--output-format=json` The same as above, the flag has no effect <img width="783" height="514" alt="image" src="https://github.com/user-attachments/assets/e5b0743a-6bd5-4dec-83e0-de24e44567ca" /> ### PR branch output, no `--output-format` Default format is now `full` rather than `concise` <img width="783" height="514" alt="image" src="https://github.com/user-attachments/assets/cf51947d-52e3-4420-83e7-73530557c324" /> ### PR branch output, `--output-format=json` JSON output, the flag works <img width="783" height="514" alt="image" src="https://github.com/user-attachments/assets/e7127c5a-88ad-4b2a-80b4-193b63b631ee" /> </p> </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR stabilizes the changes from #21097 and closes #19552. Note that this has
two effects:
--watchmode becomesfullinstead ofconcise--output-formatflag will now be respectedSo the default output is now more verbose, but the old stable behavior can be
retained by passing
--output-format=concise(or any other supported format)instead.
Test Plan
Manual testing. I think we tried to set up automated tests in an earlier PR but
decided they were too complex.
I really should have cropped these, but I'll just collapse them instead:
Screenshots
Current output, no
--output-formatCurrent output,
--output-format=jsonThe same as above, the flag has no effect
PR branch output, no
--output-formatDefault format is now
fullrather thanconcisePR branch output,
--output-format=jsonJSON output, the flag works