[ty] Fix TypedDict construction from existing TypedDict values#22904
Merged
[ty] Fix TypedDict construction from existing TypedDict values#22904
Conversation
Typing conformance resultsNo changes detected ✅ |
|
Fix false positive errors when constructing a TypedDict from an existing TypedDict value using `**unpacking` or positional argument passing. Previously, `Data(**data)` and `Data(data)` where `data: Data` would incorrectly report missing required keys because the validation logic didn't recognize that the unpacked/passed TypedDict already contains all the required fields. This change: - Updates `validate_from_keywords` to handle `**unpacking` of TypedDict values by extracting and validating all fields from the unpacked type - Adds `validate_from_typed_dict` to handle positional TypedDict arguments - Adds comprehensive tests for TypedDict construction patterns This PR handles simple intersections where just one element is a `TypedDict`. Union handling and full intersection handling will be a separate change. Fixes astral-sh/ty#2647
carljm
force-pushed
the
cjm/td-from-td
branch
from
3b88817 to
c70b062
Compare
carljm
requested review from
AlexWaygood,
dcreager and
sharkdp
as code owners
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
missing-typed-dict-key |
0 | 25 | 0 |
invalid-argument-type |
4 | 2 | 1 |
invalid-assignment |
4 | 0 | 1 |
invalid-return-type |
1 | 0 | 3 |
unused-type-ignore-comment |
2 | 0 | 0 |
| Total | 11 | 27 | 5 |
| let required_keys: OrderSet<Name> = items | ||
| .iter() | ||
| .filter_map(|(key_name, field)| field.is_required().then_some(key_name.as_str())) | ||
| .filter_map(|(key_name, field)| field.is_required().then_some(key_name.clone())) |
Member
There was a problem hiding this comment.
Sad since we don't need owned values here (but not important and hard to fix).
charliermarsh
approved these changes
Jan 28, 2026
carljm
added a commit
that referenced
this pull request
Jan 30, 2026
* main: (76 commits) [ty] Improve the check for `NewType`s with generic bases (#22961) [ty] Ban legacy `TypeVar` bounds or constraints from containing type variables (#22949) Bump the typing conformance suite pin (#22960) [ty] Emit an error if a TypeVarTuple is used to subscript `Generic` or `Protocol` without being unpacked (#22952) [ty] Reduce false positives when subscripting classes generic over `TypeVarTuple`s (#22950) [ty] Detect invalid attempts to subclass `Protocol[]` and `Generic[]` simultaneously (#22948) Fix suppression indentation matching (#22903) Remove hidden `--output-format` warning (#22944) [ty] Validate signatures of dataclass `__post_init__` methods (#22730) [ty] extend special-cased `numbers` diagnostic to `invalid-argument-type` errors (#22938) [ty] Avoid false positive for `not-iterable` with no-positive intersection types (#22089) [ty] Preserve pure negation types in descriptor protocol (#22907) [ty] add special-case diagnostic for `numbers` module (#22931) [ty] Move the location of more `invalid-overload` diagnostics (#22933) [ty] Fix unary and comparison operators for TypeVars with union bounds (#22925) [ty] Rule Selection: ignore/warn/select all rules (unless subsequently overriden) (#22832) [ty] Fix TypedDict construction from existing TypedDict values (#22904) [ty] fix bug in string annotations and clean up diagnostics (#22913) [ty] Improve support for goto-type, goto-declaration, hover, and highlighting of string annotations (#22878) [ty] Rename old typing imports to new on `unresolved-reference`. (#22827) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix false positive errors when constructing a TypedDict from an existing TypedDict value using
**unpackingor positional argument passing.Previously,
Data(**data)andData(data)wheredata: Datawould incorrectly report missing required keys because the validation logic didn't recognize that the unpacked/passed TypedDict already contains all the required fields.This change:
validate_from_keywordsto handle**unpackingof TypedDict values by extracting and validating all fields from the unpacked typeThis PR handles intersections; union handling will be a separate change.
Fixes astral-sh/ty#2647