[ty] Add diagnostic disambiguation for type aliases#22852
Merged
charliermarsh merged 3 commits intomainfrom Jan 25, 2026
Merged
[ty] Add diagnostic disambiguation for type aliases#22852charliermarsh merged 3 commits intomainfrom
charliermarsh merged 3 commits intomainfrom
Conversation
Typing conformance resultsNo changes detected ✅ |
|
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
charliermarsh
force-pushed
the
charlie/dis
branch
from
da2ee23 to
1312203
Compare
Member
|
This looks very good, but... what if a type alias has the same name as a class? class X:
type X = int
def f(x: X.X): ...
f(X())On this branch at the moment, we say: |
Member
Author
|
Hahah shoot, I was just thinking about. |
AlexWaygood
approved these changes
Jan 25, 2026
Comment on lines
445
to
449
| class Foo: | ||
| pass | ||
|
|
||
| type Foo = int # Shadows the class, but both might appear in diagnostics | ||
|
|
Member
There was a problem hiding this comment.
these two don't seem to be referenced anywhere?
Suggested change
| class Foo: | |
| pass | |
| type Foo = int # Shadows the class, but both might appear in diagnostics |
charliermarsh
force-pushed
the
charlie/dis
branch
from
1048737 to
278f868
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The intent here is to follow the implementation used for classes as closely as possible.
Closes astral-sh/ty#2606.