[ty] Fix panic when overriding final method using an assignment#22831
Merged
MichaReiser merged 1 commit intomainfrom Jan 24, 2026
Merged
[ty] Fix panic when overriding final method using an assignment#22831MichaReiser merged 1 commit intomainfrom
MichaReiser merged 1 commit intomainfrom
Conversation
Typing conformance resultsNo changes detected ✅ |
05f7609 to
d5a386f
Compare
|
AlexWaygood
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes astral-sh/ty#2602
The root cause was that the fix tried to delete the function definition even
if the method was assigned using an assignment statement.
Ideally, the fix would delete the assignment but I opted to not offer a fix in that case for now
Test Plan
Added mdtest