[ty] Avoid duplicate syntax errors for await outside functions#22826
Merged
[ty] Avoid duplicate syntax errors for await outside functions#22826
await outside functions#22826Conversation
Summary -- This PR fixes astral-sh/ty#2598 by not emitting the `YieldOutsideFunction` syntax error for `await` expressions outside of functions. This isn't the most elegant fix, but as I noted in the TODO comment, I think a better long-term fix like not emitting `YieldOutsideFunction` errors for `await` at all would change the behavior of Ruff's stable `F704` lint rule. We should be able to fix that and this TODO when resolving #19122. Test Plan -- We already had an existing mdtest for this behavior, so I just had to update it to remove the less specific error message
Typing conformance resultsNo changes detected ✅ |
|
|
Thanks so much! |
carljm
added a commit
that referenced
this pull request
Jan 30, 2026
* main: (62 commits) [`refurb`] Do not add `abc.ABC` if already present (`FURB180`) (#22234) [ty] Add a new `assert-type-unspellable-subtype` diagnostic (#22815) [ty] Avoid duplicate syntax errors for `await` outside functions (#22826) [ty] Fix unary operator false-positive for constrained TypeVars (#22783) [ty] Fix binary operator false-positive for constrained TypeVars (#22782) [ty] Fix false-positive `unsupported-operator` for "symmetric" TypeVars (#22756) [`pydocstyle`] Clarify which quote styles are allowed (`D300`) (#22825) [ty] Use distributed versions of AND and OR on constraint sets (#22614) [ty] Add support for dict literals and dict() calls as default values for parameters with TypedDict types (#22161) Document `-` stdin convention in CLI help text (#22817) [ty] Make `infer_subscript_expression_types` a method on `Type` (#22731) [ty] Simplify `OverloadLiteral::spans` and `OverloadLiteral::parameter_span` (#22823) [ty] Require both `*args` and `**kwargs` when calling a `ParamSpec` callable (#22820) [ty] Handle tagged errors in conformance (#22746) Add `--color` cli option to force colored output (#22806) Identify notebooks by LSP didOpen instead of `.ipynb` file extension (#22810) [ty] Fix docstring rendering for literal blocks after doctests (#22676) [ty] Update salsa to fix out-of-order query validation (#22498) [ty] Inline cycle initial and recovery functions (#22814) [ty] Pass the generic context through the decorator (#22544) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes astral-sh/ty#2598 by not emitting the
YieldOutsideFunctionsyntax error for
awaitexpressions outside of functions. This isn't the mostelegant fix, but as I noted in the TODO comment, I think a better long-term fix
like not emitting
YieldOutsideFunctionerrors forawaitat all would changethe behavior of Ruff's stable
F704lint rule. We should be able to fix thatand this TODO when resolving #19122.
Test Plan
We already had an existing mdtest for this behavior, so I just had to update it
to remove the less specific error message