[ty] show final search path instead of "and 1 more paths"#22776
Merged
AlexWaygood merged 1 commit intoastral-sh:mainfrom Jan 20, 2026
Merged
[ty] show final search path instead of "and 1 more paths"#22776AlexWaygood merged 1 commit intoastral-sh:mainfrom
AlexWaygood merged 1 commit intoastral-sh:mainfrom
Conversation
The subdiagnostic "and 1 more paths" isn't helpful - we can show the hidden path instead (and still have the same number of subdiagnistics).
mswart
commented
Jan 20, 2026
|
|
||
| while let Some((index, path)) = search_paths.next() { | ||
| if index > 4 && !verbose { | ||
| if index > 4 && !verbose && search_paths.peek().is_some() { |
Contributor
Author
There was a problem hiding this comment.
This could be implemented with .next(), too: we only count the items afterwards, but that feels a bit magic.
Typing conformance resultsNo changes detected ✅ |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If there are six search paths, five are attached as subdiagnostic of unresolved imports but the sixth is by default hidden and replaced by "... and 1 more paths. Run with
-vto see all paths."By hiding a single path this truncation does not shorten the output but still requires the user to rerun ty. We can just include the final search path instead.
The subdiagnostic "and 1 more paths" isn't helpful - we can show the hidden path instead (and still have the same number of subdiagnistics).
Test Plan