[ty] Emit invalid type form for stringified annotations#22752
Merged
AlexWaygood merged 1 commit intomainfrom Jan 20, 2026
Merged
[ty] Emit invalid type form for stringified annotations#22752AlexWaygood merged 1 commit intomainfrom
AlexWaygood merged 1 commit intomainfrom
Conversation
Typing conformance results improved 🎉The percentage of diagnostics emitted that were expected errors increased from 77.13% to 77.42%. The percentage of expected errors that received a diagnostic increased from 59.50% to 60.49%. Summary
True positives addedDetails
|
|
Member
Author
|
The pip diagnostic seems like a true positive: def _urllib3_request_context(
request: "PreparedRequest",
verify: "bool | str | None",
client_cert: "typing.Tuple[str, str] | str | None",
poolmanager: "PoolManager",
) -> "(typing.Dict[str, typing.Any], typing.Dict[str, typing.Any])":
... |
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
dhruvmanila
approved these changes
Jan 20, 2026
Comment on lines
+204
to
211
| # error: [invalid-type-form] "List literals are not allowed" | ||
| # error: [invalid-type-form] "Int literals are not allowed" | ||
| # error: [invalid-type-form] "Int literals are not allowed" | ||
| r: "[1, 2]" | ||
| # error: [invalid-type-form] "Tuple literals are not allowed" | ||
| # error: [invalid-type-form] "Int literals are not allowed" | ||
| # error: [invalid-type-form] "Int literals are not allowed" | ||
| s: "(1, 2)" |
Member
There was a problem hiding this comment.
Unrelated to this PR, but maybe we should avoid raising diagnostics for inner elements like "int literals" here and only emit the "list literal" diagnostic.
carljm
added a commit
that referenced
this pull request
Jan 20, 2026
* main: (149 commits) Preserve required parentheses in lambda bodies (#22747) [`flake8-simplify`] Make fix unsafe if it deletes comments (`SIM911`) (#22661) [`refurb`] Make fix unsafe if it deletes comments (`FURB145`) (#22670) [`ruff`] Make fix unsafe if it deletes comments (`RUF020`) (#22664) [ty] Add README for `ty_completion_bench` CLI tool [ty] Update completion eval [ty] Collect completions into a max-heap [ty] Truncate imports and qualifications derived from completions [ty] Get rid of high-level completion deduplication [ty] Refactor how we sort completions [ty] Optimize collection of "all symbols" [ty] Speed up completions by tweaking sorts [ty] Add new `ty_completion_bench` for ad hoc benchmarking gitignore: ignore scratch directories in completion eval truth directory [`pyupgrade`] Allow shadowing non-builtin bindings (`UP029`) (#22749) [ty] Emit invalid type form for stringified annotations (#22752) [ty] Allow `if type(x) is Y` narrowing for types other than class-literal types (#22729) [ty] Add basic support for overloads in `ParamSpec` (#21946) [`ruff`] Make fix unsafe if it deletes comments (`RUF019`) (#22663) [`flake8-bugbear`] Make fix unsafe if it deletes comments (`B014`) (#22659) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes astral-sh/ty#2553.