[ty] Fix missing syntax highlighting for aliased import names#22675
Merged
MichaReiser merged 1 commit intomainfrom Jan 18, 2026
Merged
[ty] Fix missing syntax highlighting for aliased import names#22675MichaReiser merged 1 commit intomainfrom
MichaReiser merged 1 commit intomainfrom
Conversation
MichaReiser
requested review from
AlexWaygood,
Gankra,
carljm,
dcreager and
sharkdp
as code owners
MichaReiser
added
server
MichaReiser
force-pushed
the
claude/fix-issue-2547-FX1de
branch
from
3ba3a54 to
0f98f33
Compare
AlexWaygood
approved these changes
Jan 18, 2026
When using `from X import Y as Z`, only the alias (Z) was receiving syntax highlighting, while the original import name (Y) was not being highlighted at all. This fix ensures both the imported name and its alias receive consistent syntax highlighting with the same token type. Fixes: astral-sh/ty#2547
MichaReiser
force-pushed
the
claude/fix-issue-2547-FX1de
branch
from
0f98f33 to
44bc103
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using
from X import Y as Z, only the alias (Z) was receiving syntax highlighting, while the original import name (Y) was not being highlighted at all. This fix ensures both the imported name and its alias receive consistent syntax highlighting with the same token type.Fixes: astral-sh/ty#2547
Test Plan
Added test