[ty] Support overriding respect-type-ignore-comments#22615
Merged
MichaReiser merged 3 commits intomainfrom Jan 19, 2026
Merged
Conversation
MichaReiser
requested review from
Gankra,
dcreager and
sharkdp
as code owners
MichaReiser
added
configuration
Typing conformance resultsNo changes detected ✅ |
MichaReiser
commented
Jan 16, 2026
Comment on lines
+1611
to
+1617
| let mut merged_analysis = analysis.into_owned(); | ||
|
|
||
| if let Some(global_analysis) = global_analysis { | ||
| merged_analysis = merged_analysis.combine(global_analysis.clone()); | ||
| } | ||
|
|
||
| let analysis = merged_analysis.to_settings(); |
Member
Author
There was a problem hiding this comment.
When we start adding analysis options that can't be overriden (like a strict mode), we then have to warn here that this specific override setting was ignored OR define a separate OverrideAnalysisOptions that only defines the subset of options allowed in this section (so that editors don't provide completions for options that aren't allowed). However, this is something that we can figure out once we have non-overridable analysis options.
|
|
AlexWaygood
changed the title
respect-type-ignore-comments
charliermarsh
approved these changes
Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for overriding
respect-type-ignore-commentsin theoverridessection.Fixes astral-sh/ty#2530
Test Plan
Added CLI tests