[ty] Fix __file__ type in completions to show str instead of str | None#22510
Merged
charliermarsh merged 2 commits intomainfrom Jan 12, 2026
Merged
[ty] Fix __file__ type in completions to show str instead of str | None#22510charliermarsh merged 2 commits intomainfrom
__file__ type in completions to show str instead of str | None#22510charliermarsh merged 2 commits intomainfrom
Conversation
charliermarsh
added
server
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
charliermarsh
requested review from
AlexWaygood,
Gankra,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
Contributor
|
A related PR which is the semantics side for handling |
BurntSushi
reviewed
Jan 12, 2026
| builtin: true, | ||
| }), | ||
| ); | ||
|
|
Member
There was a problem hiding this comment.
Do we still need to get completions from the builtins module below if we're doing this?
Member
There was a problem hiding this comment.
yeah, this special case is only for the 8 or so "implicit module globals" that are present in every global namespace. Previously we only "accidentally" recognized them as being available in our autocompletion engine because they are present in the builtins-module global namespace just like every other module-global namespace. But treating them as builtin symbols was incorrect, because they might have more precise types in the global namespace of the current module than they do in the builtins module's global namespace.
So for all builtins symbols other than these 8 or so special-cased symbols, we still need to import the builtins module and lookup the global namespace as we do below.
AlexWaygood
approved these changes
Jan 12, 2026
| builtin: true, | ||
| }), | ||
| ); | ||
|
|
Member
There was a problem hiding this comment.
yeah, this special case is only for the 8 or so "implicit module globals" that are present in every global namespace. Previously we only "accidentally" recognized them as being available in our autocompletion engine because they are present in the builtins-module global namespace just like every other module-global namespace. But treating them as builtin symbols was incorrect, because they might have more precise types in the global namespace of the current module than they do in the builtins module's global namespace.
So for all builtins symbols other than these 8 or so special-cased symbols, we still need to import the builtins module and lookup the global namespace as we do below.
Co-authored-by: Alex Waygood <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The type inference system already correctly special-cases
__file__to returnstrfor the current module (since the code is executing from an existing file). However, the completion system was bypassing this logic and pulling__file__: str | Nonedirectly fromtypes.ModuleTypein typeshed.This PR adds implicit module globals (like
__file__,__name__, etc.) with their correctly-typed values to completions, reusing the existingmodule_type_implicit_global_symbolfunction that already handles the special-casing.Closes astral-sh/ty#2445.