[ty] Avoid emitting Liskov repeated violations from grandparent to child#22484
Merged
charliermarsh merged 1 commit intomainfrom Jan 10, 2026
Merged
[ty] Avoid emitting Liskov repeated violations from grandparent to child#22484charliermarsh merged 1 commit intomainfrom
charliermarsh merged 1 commit intomainfrom
Conversation
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
f83f7cd to
e1b5c6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If parent violates LSP against grandparent, and child has the same violation (but matches parent), we no longer flag the LSP violation on child, since it can't be fixed without violating parent.
If parent violates LSP against grandparent, and child violates LSP against both parent and grandparent, we emit two diagnostics (one for each violation).
If parent violates LSP against grandparent, and child violates LSP against parent (but not grandparent), we flag it.
Closes astral-sh/ty#2000.