[ty] Enable unused-ignore-comment by default#22474
Merged
MichaReiser merged 4 commits intomainfrom Jan 9, 2026
Merged
Conversation
MichaReiser
requested review from
AlexWaygood,
dcreager and
sharkdp
as code owners
MichaReiser
added
configuration
Diagnostic diff on typing conformance testsChanges were detected when running ty on typing conformance tests--- old-output.txt 2026-01-09 10:56:08.437298717 +0000
+++ new-output.txt 2026-01-09 10:56:08.736299323 +0000
@@ -228,6 +228,7 @@
constructors_call_new.py:125:42: error[invalid-return-type] Function always implicitly returns `None`, which is not assignable to return type `Self@__new__`
constructors_call_new.py:140:47: error[invalid-return-type] Function always implicitly returns `None`, which is not assignable to return type `Class11[int]`
constructors_call_new.py:145:1: error[invalid-argument-type] Argument to function `__new__` is incorrect: Expected `type[Class11[int]]`, found `<class 'Class11[str]'>`
+constructors_call_type.py:19:55: warning[unused-ignore-comment] Unused blanket `type: ignore` directive
constructors_call_type.py:40:5: error[missing-argument] No arguments provided for required parameters `x`, `y` of function `__new__`
constructors_call_type.py:50:5: error[missing-argument] No arguments provided for required parameters `x`, `y` of bound method `__init__`
constructors_call_type.py:59:9: error[too-many-positional-arguments] Too many positional arguments to bound method `__init__`: expected 1, got 2
@@ -391,6 +392,11 @@
directives_reveal_type.py:19:5: error[missing-argument] No argument provided for required parameter `obj` of function `reveal_type`
directives_reveal_type.py:20:20: error[too-many-positional-arguments] Too many positional arguments to function `reveal_type`: expected 1, got 2
directives_type_checking.py:11:14: error[invalid-assignment] Object of type `Literal[""]` is not assignable to `int`
+directives_type_ignore_file1.py:11:7: warning[unused-ignore-comment] Unused blanket `type: ignore` directive
+directives_type_ignore_file1.py:14:17: warning[unused-ignore-comment] Unused blanket `type: ignore` directive
+directives_type_ignore_file2.py:7:1: warning[unused-ignore-comment] Unused blanket `type: ignore` directive
+directives_type_ignore_file2.py:9:7: warning[unused-ignore-comment] Unused blanket `type: ignore` directive
+directives_type_ignore_file2.py:12:17: warning[unused-ignore-comment] Unused blanket `type: ignore` directive
directives_type_ignore_file2.py:14:10: error[invalid-assignment] Object of type `Literal[""]` is not assignable to `int`
directives_version_platform.py:14:17: error[invalid-assignment] Object of type `Literal[""]` is not assignable to `int`
directives_version_platform.py:19:17: error[invalid-assignment] Object of type `Literal[""]` is not assignable to `int`
@@ -1023,4 +1029,4 @@
typeddicts_usage.py:28:17: error[missing-typed-dict-key] Missing required key 'name' in TypedDict `Movie` constructor
typeddicts_usage.py:28:18: error[invalid-key] Unknown key "title" for TypedDict `Movie`: Unknown key "title"
typeddicts_usage.py:40:24: error[invalid-type-form] The special form `typing.TypedDict` is not allowed in type expressions
-Found 1025 diagnostics
+Found 1031 diagnostics
|
|
Member
Author
|
The typing conformance results are a bit funny. ty picks up the nested # > A # type: ignore comment on a line by itself at the top of a file, before any
# > docstrings, imports, or other executable code, silences all errors in the file.
# > Blank lines and other comments, such as shebang lines and coding cookies, may
# > precede the # type: ignore comment.I think that's fine |
Member
Author
|
Hmm, why do we see changes on mypy primer. Does our mypy primer override no longer work? |
AlexWaygood
approved these changes
Jan 9, 2026
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Nice. I still think a subdiagnostic that mentions the config option would be good, if we're emitting the diagnostic on a type: ignore comment rather than a ty: ignore comment. And I think we should definitely mention the config option in the docs for the rule.
| @@ -24,10 +24,10 @@ use crate::{Db, declare_lint, lint::LintId}; | |||
|
|
|||
| declare_lint! { | |||
Member
There was a problem hiding this comment.
We should mention and link to the configuration option in the docs here, in case users get confused about ty complaining about ignore comments they have in place for other type checkers
Member
Author
This seems noisy to me. It's an extra line that you always see. |
Member
|
We can consider it separately, it doesn't need to block this |
Member
Author
|
Ahh no. The reason we see the mypy primer changes is because we use the same (the new) configuration for both the baseline and the new ty binary but the old ty binary required explicilty enabling the rule |
NickButcher1
added a commit
to Oxford-Bee-Ops/expidite
that referenced
this pull request
Jan 11, 2026
They enabled unused-type-ignore-comment as per astral-sh/ruff#22474 which required a few code changes: - cloud_connector - simplify and prefer match over mutliple if tests anyway for an enum - remove several ignores which were simply not needed any more (ty correctly doing its job!) - dp_node - correctly set a type to include None - edge_orchestrator remove unused __new__ - the same function (which IS used) is in get_instance() - add some types where missing
|
Isn't the rule |
AlexWaygood
changed the title
unused-type-ignore-comment by defaultunused-ignore-comment by default
|
It's also |
Member
|
Thanks, this is fixed in https://github.com/astral-sh/ty/releases/tag/0.0.11 and I've put up a PR for the changelog: astral-sh/ty#2461 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes astral-sh/ty#278