[ty] Rank top-level module symbols above most other symbols#22465
Merged
BurntSushi merged 1 commit intomainfrom Jan 9, 2026
Merged
[ty] Rank top-level module symbols above most other symbols#22465BurntSushi merged 1 commit intomainfrom
BurntSushi merged 1 commit intomainfrom
Conversation
BurntSushi
requested review from
AlexWaygood,
Gankra,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
BurntSushi
added
server
MichaReiser
approved these changes
Jan 9, 2026
BurntSushi
force-pushed
the
ag/ranking-improvements
branch
from
6ff8447 to
d9d8596
Compare
BurntSushi
force-pushed
the
ag/rank-module-names-higher
branch
from
367a0e1 to
f1328f9
Compare
BurntSushi
force-pushed
the
ag/ranking-improvements
branch
from
d9d8596 to
15cc74e
Compare
BurntSushi
force-pushed
the
ag/rank-module-names-higher
branch
from
f1328f9 to
6dda55c
Compare
This makes it so, e.g., `os<CURSOR>` will suggest the top-level stdlib `os` module even if there is an `os` symbol elsewhere in your project. The way this is done is somewhat overwrought, but it's done to avoid suggesting top-level modules over other symbols already in scope. Fixes astral-sh/issues#1852
BurntSushi
force-pushed
the
ag/rank-module-names-higher
branch
from
6dda55c to
858d2a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so, e.g.,
os<CURSOR>will suggest the top-level stdlibosmodule even if there is anossymbol elsewhere in your project.The way this is done is somewhat overwrought, but it's done to avoid
suggesting top-level modules over other symbols already in scope.
Fixes astral-sh/ty#1852