[ty] Link to Callable __name__ FAQ directly from unresolved-attribute diagnostic#22437
Merged
AlexWaygood merged 2 commits intomainfrom Jan 7, 2026
Merged
[ty] Link to Callable __name__ FAQ directly from unresolved-attribute diagnostic#22437AlexWaygood merged 2 commits intomainfrom
Callable __name__ FAQ directly from unresolved-attribute diagnostic#22437AlexWaygood merged 2 commits intomainfrom
Conversation
…ibute` diagnostic
AlexWaygood
added
ty
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
MichaReiser
reviewed
Jan 7, 2026
Comment on lines
+10120
to
+10121
| <https://docs.astral.sh/ty/reference/typing-faq/\ | ||
| #why-does-ty-say-callable-has-no-attribute-__name__>", |
Member
There was a problem hiding this comment.
How does this render on a terminal? Do we need to wrap the url in <>?
Member
Author
There was a problem hiding this comment.
How does this render on a terminal?
like this:
Do we need to wrap the url in
<>?
Yes (as I've done) -- without the <> around the URL, if I double click on the URL in the terminal it tries to load https://docs.astral.sh/ty/reference/typing-faq/#why-does-ty-say-callable-has-no-attribute-__name (without the __ suffix at the end of the URL). That doesn't exist, so the page loaded in the browser opens at the top of the FAQs page
MichaReiser
reviewed
Jan 7, 2026
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
My only concern with this is that it adds more URLs that we add more dependencies on how our docs are structured.
Member
Author
yeah, definitely a downside. It seems far more user-friendly to link to the FAQ directly to the diagnostic, though, and not a huge maintenance burden for us. If a user notices that the link in the diagnostic goes stale, it's very trivial for us to update it in a PR. |
Member
But that only works for new ty versions ;) What we do for Ruff is maintain URL stability and that's not a lot of work but requires extra care |
MichaReiser
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I think this would have helped with astral-sh/ty#2375
Test Plan
Snapshots updated